sentry icon indicating copy to clipboard operation
sentry copied to clipboard

[Replay Search] Support null/empty queries for IP field.

Open aliu39 opened this issue 5 months ago • 0 comments

Problem Statement

Because of the way we parse fields on the backend, we don't allow "" or None/none for user.ip filters. We just show an error banner instead.

Reported in https://github.com/getsentry/sentry/issues/78286#issuecomment-2387065115. Searching for replays without an IP seems like a valid usecase.

Solution Brainstorm

Allow None in the parser(s) and translate "" and "none" strings into this.

Need to investigate if we can pass python None into the snuba queries. Should be fine since the column is nullable.


Follow-ups

If there's any field in the future that is

  • a UUID
  • scalar (not a list)
  • nullable/optional (so not id) We also have to handle this. Can probably make a separate parser, parse_uuid_nullable.

Product Area

Replays

aliu39 avatar Oct 03 '24 23:10 aliu39