sentry icon indicating copy to clipboard operation
sentry copied to clipboard

test(ui): Add types to RouterFixture

Open scttcper opened this issue 1 year ago • 1 comments

Adds a few expected properties to RouterFixture to help with autocomplete

scttcper avatar Oct 02 '24 23:10 scttcper

:x: 15 Tests Failed:

Tests completed Failed Passed Skipped
7911 15 7896 0
View the top 3 failed tests by shortest run time
Modals -> WidgetViewerModal Discover Widgets TopN Chart Widget sorts table when a sortable column header is clicked Modals -> WidgetViewerModal Discover Widgets TopN Chart Widget sorts table when a sortable column header is clicked
Stack Traces | 0.178s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: "........./organizations/org-slug/events/", ObjectContaining {"query": ObjectContaining {"sort": ["-count()"]}}
Received
       1: "........./organizations/org-slug/events/", {"error": [Function error], "method": "GET", "query": {"cursor": undefined, "dataset": undefined, "display": undefined, "environment": ["prod", "dev"], "field": ["error.type", "count()"], "id": undefined, "interval": undefined, "name": "", "onDemandType": "dynamic_query", "per_page": 10, "project": ["1", "2"], "query": "title:/organizations/:orgId/performance/summary/", "referrer": "api.dashboards.tablewidget", "sort": undefined, "statsPeriod": "24h", "topEvents": undefined, "useOnDemandMetrics": false, "widths": undefined, "yAxis": "count()"}, "skipAbort": undefined, "success": [Function success]}
       2: "........./organizations/org-slug/events/", {"error": [Function error], "method": "GET", "query": {"cursor": undefined, "dataset": undefined, "display": undefined, "environment": ["prod", "dev"], "field": ["error.type", "count()"], "id": undefined, "interval": undefined, "name": "", "onDemandType": "dynamic_query", "per_page": 10, "project": ["1", "2"], "query": "title:/organizations/:orgId/performance/summary/", "referrer": "api.dashboards.tablewidget", "sort": undefined, "statsPeriod": "24h", "topEvents": undefined, "useOnDemandMetrics": false, "widths": undefined, "yAxis": "count()"}, "skipAbort": undefined, "success": [Function success]}

Number of calls: 2
    at Object.<anonymous> (.../components/modals/widgetViewerModal.spec.tsx:771:28)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at processTimers (node:internal/timers:514:7)
Modals -> WidgetViewerModal Discover Widgets Area Chart Widget updates selected query when selected in the query dropdown Modals -> WidgetViewerModal Discover Widgets Area Chart Widget updates selected query when selected in the query dropdown
Stack Traces | 0.362s run time
TestingLibraryElementError: Unable to find an element with the text: Another Query Name. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../components/modals/widgetViewerModal.spec.tsx:370:44)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processTimers (node:internal/timers:511:9)
Performance > VitalDetail can switch vitals with dropdown menu Performance > VitalDetail can switch vitals with dropdown menu
Stack Traces | 0.407s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

- Expected
+ Received

  Object {
-   "pathname": undefined,
+   "pathname": "/mock-pathname/",
    "query": Object {
+     "cursor": undefined,
      "project": 1,
      "query": "tag:value",
      "vitalName": "measurements.fcp",
    },
  },

Number of calls: 1
    at Object.<anonymous> (.../performance/vitalDetail/index.spec.tsx:359:49)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov[bot] avatar Oct 02 '24 23:10 codecov[bot]