sentry icon indicating copy to clipboard operation
sentry copied to clipboard

chore(ui): Remove searchbar releases flag

Open schew2381 opened this issue 1 year ago • 2 comments

Removing the search-query-builder-releases from FE

schew2381 avatar Oct 01 '24 22:10 schew2381

:x: 2 Tests Failed:

Tests completed Failed Passed Skipped
7996 2 7994 0
View the top 2 failed tests by shortest run time
ReleasesList displays request errors ReleasesList displays request errors
Stack Traces | 0.349s run time
TestingLibraryElementError: Unable to find an element with the placeholder text of: Search by version, build, package, or stage

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../releases/list/index.spec.tsx:272:40)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processTimers (node:internal/timers:511:9)
ReleasesList autocompletes semver search tag ReleasesList autocompletes semver search tag
Stack Traces | 1.32s run time
Error: Unable to find an element by: [data-test-id="smart-search-input"]

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../releases/list/index.spec.tsx:587:62)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at processTimers (node:internal/timers:514:7)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov[bot] avatar Oct 01 '24 22:10 codecov[bot]

Looks like there are some failing tests that were looking for the old search bar. You'll need to modify them to interact with the new search bar component. Instead of looking for a textbox, you'll need to do something like this:

const input = await screen.getByRole('combobox', {name: 'Add a search term'})
await userEvent.paste('test-key:10');

malwilley avatar Oct 02 '24 19:10 malwilley