sentry icon indicating copy to clipboard operation
sentry copied to clipboard

demo: CI failing when test is moved and renamed

Open lobsterkatie opened this issue 1 year ago • 1 comments

Demo of the fact that moving/renaming one test file is causing another unrelated test file to consistently crash (always the same tests in the same file).

@joshferge suggested maybe it has to do with sharding - perhaps the tests in the crashing file are interdependent and the move/rename of my file caused necessary ones to land in a different shard.

Debugging already done:

  • All tests in the crashing file run fine locally on this branch
  • The tests in the crashing file are indeed distributed across multiple shards.
  • Tried to run a few of the failing tests locally, each as the only test that runs (so if it's dependent on another test, it should fail because that test won't run). All passed.
  • Tried moving the file without rename - CI passes. Tried renaming the file without moving it - CI passes. Combining both makes CI fail.
  • Tried moving the changes to a new branch (shouldn't matter, but you never know).
  • Tried rebasing on master, any number of times over the past handful of days.

lobsterkatie avatar Oct 01 '24 19:10 lobsterkatie

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #78418       +/-   ##
===========================================
+ Coverage   57.37%   78.10%   +20.73%     
===========================================
  Files        7064     7076       +12     
  Lines      311412   311937      +525     
  Branches    50866    50940       +74     
===========================================
+ Hits       178675   243643    +64968     
+ Misses     128009    61940    -66069     
- Partials     4728     6354     +1626     

codecov[bot] avatar Oct 01 '24 19:10 codecov[bot]

Solved in https://github.com/getsentry/sentry/pull/78528.

lobsterkatie avatar Oct 04 '24 18:10 lobsterkatie