sentry icon indicating copy to clipboard operation
sentry copied to clipboard

Inconsistent session replay search results

Open masinette opened this issue 1 year ago • 8 comments

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. navigate to Session Replay main page
  2. search user.email is not ""
  3. compare results of this search to the unfiltered results

Expected Result

All of the replays with a user email appear on the list for the user.email is not "" search

Image

Actual Result

Some results that appeared in the unfiltered search (and had a user email) do not appear in the filtered search

Unfiltered search: Image

Filtered search: Image

Product Area

Replays

Link

No response

DSN

No response

Version

No response

masinette avatar Sep 27 '24 20:09 masinette

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] avatar Sep 27 '24 20:09 getsantry[bot]

Routing to @getsentry/product-owners-replays for triage ⏲️

getsantry[bot] avatar Sep 30 '24 17:09 getsantry[bot]

Hey @masinette 👋

Thanks for raising this.

The inconsistent search results for the "user.email is not """ search is indeed odd. I've been able to repro this on my laptop. I'm not entirely sure if our 'is not' syntax can work in this way when the value is empty 😅

What is the use-case/rationale for someone searching for this?

jas-kas avatar Oct 01 '24 19:10 jas-kas

Filtering out users who are not signed in

staticshock avatar Oct 01 '24 20:10 staticshock

I also tried user.ip is "" and user.ip is None, since the list displays IPs when an email is not available, but both of those queries crashed. After that I ran out of steam looking for ways to get the output I was looking for.

staticshock avatar Oct 01 '24 20:10 staticshock

Also, it's not just the is not operator. user.email is "" returns weird results, too. In my project, that returns at least some rows where users clearly have an email.

staticshock avatar Oct 01 '24 21:10 staticshock

IP bug relates to https://github.com/getsentry/sentry/pull/69326/files

We're looking into both of these issues, thanks for reporting! @staticshock @masinette

aliu39 avatar Oct 02 '24 21:10 aliu39

@staticshock the IP bug you discovered should be fixed by https://github.com/getsentry/sentry/pull/78642

aliu39 avatar Oct 04 '24 23:10 aliu39

Thank you, after this release the issue appears fixed in production :)

staticshock avatar Oct 17 '24 00:10 staticshock