sentry icon indicating copy to clipboard operation
sentry copied to clipboard

React Router 6 [✅ ENABLED]

Open evanpurkhiser opened this issue 1 year ago • 1 comments

This PR tests a full react-router 6 compatibility layer ✅ WITH react-router 6 in use.

All tests should pass

evanpurkhiser avatar Aug 21 '24 18:08 evanpurkhiser

Codecov Report

Attention: Patch coverage is 47.57282% with 108 lines in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files Patch % Lines
static/app/utils/browserHistory.tsx 3.12% 31 Missing :warning:
static/app/utils/useRouter.tsx 8.00% 22 Missing and 1 partial :warning:
static/app/utils/reactRouter6Compat/router.tsx 66.66% 18 Missing :warning:
static/app/utils/useRoutes.tsx 15.38% 10 Missing and 1 partial :warning:
static/app/utils/useNavigate.tsx 14.28% 5 Missing and 1 partial :warning:
static/app/utils/useLocation.tsx 28.57% 4 Missing and 1 partial :warning:
static/app/main.tsx 0.00% 3 Missing :warning:
static/app/utils/reactRouter6Compat/location.tsx 78.57% 3 Missing :warning:
static/app/components/globalSelectionLink.tsx 50.00% 1 Missing and 1 partial :warning:
static/app/utils/useParams.tsx 50.00% 1 Missing and 1 partial :warning:
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #76464      +/-   ##
==========================================
- Coverage   78.16%   78.13%   -0.03%     
==========================================
  Files        6894     6896       +2     
  Lines      306749   306937     +188     
  Branches    52794    52832      +38     
==========================================
+ Hits       239757   239827      +70     
- Misses      60604    60714     +110     
- Partials     6388     6396       +8     

codecov[bot] avatar Aug 21 '24 18:08 codecov[bot]

Superseded by https://github.com/getsentry/sentry/pull/76471

evanpurkhiser avatar Aug 27 '24 20:08 evanpurkhiser