sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(settings): Convert org members list to functional

Open scttcper opened this issue 1 year ago • 3 comments

this component was using AsyncComponent's renderSearchInput

combines the organizationMembersWrapper into the organizationMembers component instead of using the router to pass in some loaded data from above.

scttcper avatar Aug 16 '24 23:08 scttcper

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Sep 07 '24 07:09 getsantry[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Sep 30 '24 07:09 getsantry[bot]

:x: 2 Tests Failed:

Tests completed Failed Passed Skipped
7912 2 7910 0
View the top 2 failed tests by shortest run time
OrganizationMembersList can redirect to remaining org after leaving OrganizationMembersList can redirect to remaining org after leaving
Stack Traces | 0.27s run time
Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../settings/organizationMembers/organizationMembersList.spec.tsx:250:25)
OrganizationMembersList can leave org OrganizationMembersList can leave org
Stack Traces | 0.356s run time
Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../settings/organizationMembers/organizationMembersList.spec.tsx:221:25)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov[bot] avatar Sep 30 '24 21:09 codecov[bot]