fix(ecosystem): Propagate test alert errors to the UI, behind a flag
Adds error propagation for test alert rules, behind 2 flags:
-
projects:verbose-test-alert-reporting- Which opts projects/orgs into verbose error reporting -
ecosystem:enable_integration_form_error_raise- Option check for whether or not to raise errors fromIntegrationFormErrorswhen creating tickets.
When both of these flags are enabled, the user will receive explicit error messages in the UI if a test alert rule generates an IntegrationError, which typically happens when an API call to the provider fails.
Here are a couple of examples from our Jira integration of failed alert tests, first with an invalid team string:
And second, with an invalid Date property from another bug with the Jira form:
The customfield_<id> error is some additional tech debt due to us only surfacing IntegrationFormErrors with Jira field ID instead of the display name they provide us, and will be handled in yet another follow-up PR.
Codecov Report
Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/sentry/api/endpoints/project_rule_actions.py | 89.28% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #76369 +/- ##
===========================================
+ Coverage 56.86% 78.18% +21.32%
===========================================
Files 6888 6898 +10
Lines 306288 306678 +390
Branches 50225 50274 +49
===========================================
+ Hits 174168 239776 +65608
+ Misses 127422 60493 -66929
- Partials 4698 6409 +1711