sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(onboarding): frontend for disableMemberInvite flag

Open ameliahsu opened this issue 1 year ago • 3 comments

add toggle for org admin to allow/disallow members from inviting teammates to their org

Admin view: admin_view

Non-admin view (toggle is disabled): member_view

ameliahsu avatar Aug 13 '24 17:08 ameliahsu

Bundle Report

Changes will increase total bundle size by 7.0kB :arrow_up:

Bundle name Size Change
app-webpack-bundle-array-push 30.24MB 7.0kB :arrow_up:

codecov[bot] avatar Aug 13 '24 18:08 codecov[bot]

Can you please add a screenshot for what others will see who are not org admins?

sentaur-athena avatar Aug 16 '24 18:08 sentaur-athena

I'm not sure if you like to add this change to this PR or the next one, but commented any ways. Looks good otherwise.

sentaur-athena avatar Aug 26 '24 23:08 sentaur-athena

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tic/app/data/forms/organizationGeneralSettings.tsx 83.33% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #76085      +/-   ##
==========================================
- Coverage   78.15%   78.15%   -0.01%     
==========================================
  Files        6903     6905       +2     
  Lines      307221   307228       +7     
  Branches    52875    52866       -9     
==========================================
+ Hits       240104   240107       +3     
- Misses      60705    60776      +71     
+ Partials     6412     6345      -67     

codecov[bot] avatar Aug 27 '24 20:08 codecov[bot]