sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(discover): Adds cache_miss_rate function to discover metrics dataset

Open edwardgou-sentry opened this issue 1 year ago • 1 comments

Adds the cache_miss_rate function to the discover metrics dataset

edwardgou-sentry avatar Aug 09 '24 01:08 edwardgou-sentry

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files Patch % Lines
src/sentry/search/events/datasets/metrics.py 88.88% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #75896       +/-   ##
===========================================
- Coverage   90.49%   78.27%   -12.23%     
===========================================
  Files        3099     6824     +3725     
  Lines      193934   303955   +110021     
  Branches        0    52289    +52289     
===========================================
+ Hits       175504   237923    +62419     
- Misses      18430    59644    +41214     
- Partials        0     6388     +6388     

codecov[bot] avatar Aug 09 '24 02:08 codecov[bot]

There's some duplicate resolve functions between this metrics dataset and the spans_metrics dataset. Planning to look into consolidating these in a later pr

edwardgou-sentry avatar Aug 12 '24 17:08 edwardgou-sentry