sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(custom-views): Add custom views to issue stream behind feature flag

Open MichaelSun48 opened this issue 1 year ago • 2 comments

This PR releases the custom views feature into the issue stream under a feature flag. Flagged users will also see the "Custom Search" button has been removed from the issue stream in favor of custom views. The bulk of this new component exists in <CustomViewsIssueListHeader/>, whose parent component is in overview.tsx.

Several changes have also been made to the base draggable tab components to iron out any compatibility issues that did not appear during sandbox development.

Things that are still broken that I am actively working on:

  • Tab Renaming is both ugly and broken (can't type in spaces)
  • Tab overflow logic does not exist at all
  • QueryCounts do not work for any tabs with queries that do not match queries of previous default tabs
  • Some queries that are functionally the same but off by a space register as different, thus triggering the "unsaved changes" state.
  • Tabs do not animate in when added, nor do they animate out when deleted
  • No loading or failure state for tabs request
  • Stories is busted as a result of all of the changes made to base tabs components

MichaelSun48 avatar Aug 08 '24 21:08 MichaelSun48

Bundle Report

Changes will increase total bundle size by 658.22kB :arrow_up:

Bundle name Size Change
app-webpack-bundle-array-push 29.51MB 658.22kB :arrow_up:

codecov[bot] avatar Aug 08 '24 21:08 codecov[bot]

:x: 1 Tests Failed:

Tests completed Failed Passed Skipped
7668 1 7667 0
View the top 1 failed tests by shortest run time
trace view keyboard navigation roving updates the element in the drawertrace view keyboard navigation roving updates the element in the drawer
Stack Traces | 3s run time
Error: Unable to find an element with the text: /transaction-op-0/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
at keyboardNavigationTestSetup (.../performance/newTraceDetails/trace.spec.tsx:261:52)
at Object.<anonymous> (.../performance/newTraceDetails/trace.spec.tsx:706:17)
at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
at new Promise (<anonymous>)
at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
at runNextTicks (node:internal/process/task_queues:60:5)
at listOnTimeout (node:internal/timers:540:9)
at processTimers (node:internal/timers:514:7)
at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov[bot] avatar Aug 08 '24 21:08 codecov[bot]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading '0'): /issues /issues View Issue

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Aug 16 '24 16:08 sentry[bot]

PR reverted: 3a79696eff460001b5f505fec8512b2fb8d5c020

getsentry-bot avatar Aug 16 '24 16:08 getsentry-bot