sentry icon indicating copy to clipboard operation
sentry copied to clipboard

ref(insights): remove unused All module

Open mjq opened this issue 1 year ago • 2 comments

The "All" module is a holdover from the very early days of Starfish and not used anywhere. Remove it.

mjq avatar Aug 08 '24 20:08 mjq

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

:x: Failed Test Results:

Completed 7605 tests with 1 failed, 7604 passed and 0 skipped.

View the full list of failed tests

ResourcesLandingPage

  • Class name: ResourcesLandingPage fetches domain data
    Test name: ResourcesLandingPage fetches domain data Flags:
    • frontend

    Error: expect(received).toMatchInlineSnapshot(snapshot)

    Snapshot name: `ResourcesLandingPage fetches domain data 1`

    - Snapshot - 1
    + Received + 1

    @@ -11,11 +11,11 @@
    "span.domain",
    "count()",
    ],
    "per_page": 100,
    "project": [],
    - "query": "has:span.description !span.description:"browser-extension://*" span.op:[resource.script,resource.css,resource.font,resource.img]",
    + "query": "has:span.description span.module:resource !span.description:"browser-extension://*" span.op:[resource.script,resource.css,resource.font,resource.img]",
    "referrer": "api.starfish.get-span-domains",
    "sort": "-count",
    "statsPeriod": "10d",
    },
    "skipAbort": undefined,
    at Object.<anonymous> (.../resources/views/resourcesLandingPage.spec.tsx:75:52)

codecov[bot] avatar Aug 08 '24 20:08 codecov[bot]

Bundle Report

Changes will decrease total bundle size by 1.02kB :arrow_down:

Bundle name Size Change
app-webpack-bundle-array-push 28.72MB 1.02kB :arrow_down:

codecov[bot] avatar Aug 10 '24 01:08 codecov[bot]