sentry icon indicating copy to clipboard operation
sentry copied to clipboard

chore(hybridcloud) Move outbox model to sentry.hybridcloud

Open markstory opened this issue 1 year ago • 1 comments

Move the model classes to sentry.hybridcloud and update imports. Shims have been left behind to allow getsentry imports to continue working.

markstory avatar Aug 08 '24 14:08 markstory

Codecov Report

Attention: Patch coverage is 93.35443% with 21 lines in your changes missing coverage. Please review.

Project coverage is 78.24%. Comparing base (0f49ac8) to head (550c72a).

Files Patch % Lines
src/sentry/hybridcloud/models/outbox.py 92.66% 13 Missing and 6 partials :warning:
src/sentry/hybridcloud/outbox/base.py 77.77% 2 Missing :warning:
Additional details and impacted files
@@                    Coverage Diff                    @@
##           chore-outbox-move-tasks   #75826    +/-   ##
=========================================================
  Coverage                    78.24%   78.24%            
=========================================================
  Files                         6815     6839    +24     
  Lines                       303669   303809   +140     
  Branches                     52232    52271    +39     
=========================================================
+ Hits                        237604   237730   +126     
- Misses                       59681    59695    +14     
  Partials                      6384     6384            
Files Coverage Δ
src/sentry/api/endpoints/api_authorizations.py 88.88% <100.00%> (ø)
src/sentry/api/endpoints/api_tokens.py 100.00% <100.00%> (ø)
...oints/organization_member/requests/invite/index.py 95.12% <100.00%> (ø)
...api/endpoints/organization_member/requests/join.py 96.36% <100.00%> (ø)
src/sentry/audit_log/services/log/impl.py 93.47% <100.00%> (ø)
src/sentry/auth/helper.py 92.16% <100.00%> (ø)
src/sentry/auth/services/auth/impl.py 67.74% <100.00%> (ø)
src/sentry/auth/services/orgauthtoken/impl.py 87.50% <100.00%> (ø)
src/sentry/backup/imports.py 90.39% <100.00%> (ø)
src/sentry/backup/services/import_export/impl.py 84.12% <100.00%> (ø)
... and 35 more

... and 52 files with indirect coverage changes

codecov[bot] avatar Aug 08 '24 21:08 codecov[bot]

Changes look good. Any idea why the openAPI diff is failing though?

GabeVillalobos avatar Aug 09 '24 15:08 GabeVillalobos

Changes look good. Any idea why the openAPI diff is failing though?

I think this is from a stale merge base. The commitauthor.email serializer field length was bumped up recently in #72118

markstory avatar Aug 09 '24 16:08 markstory

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: OperationalError('server closed the connection unexpectedly\n\tThis probably means the server ter... sentry.tasks.drain_outbox_shards View Issue
  • ‼️ OperationalError: OperationalError('server closed the connection unexpectedly\n\tThis probably means the server ter... /api/0/organizations/{organization_id_or_slug}/... View Issue
  • ‼️ OperationalError: OperationalError('server closed the connection unexpectedly\n\tThis probably means the server ter... /api/0/organizations/{organization_id_or_slug}/... View Issue
  • ‼️ OperationalError: OperationalError('server closed the connection unexpectedly\n\tThis probably means the server ter... /oauth/token/ View Issue
  • ‼️ OperationalError: OperationalError('server closed the connection unexpectedly\n\tThis probably means the server ter... /api/0/organizations/ View Issue

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Aug 09 '24 22:08 sentry[bot]