sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(anomaly detection): Add anomaly detection alerts option + preliminary work for new form fields

Open mifu67 opened this issue 1 year ago • 3 comments

Add the option for anomaly detection alerts. When the user clicks on the option, render something different as a placeholder. (The orange border is just to highlight the change.)

https://github.com/user-attachments/assets/a5f55b1d-c7c8-4d54-bdd4-d072ea918aa2

mifu67 avatar Aug 07 '24 23:08 mifu67

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

github-actions[bot] avatar Aug 07 '24 23:08 github-actions[bot]

Bundle Report

Changes will increase total bundle size by 47.07kB :arrow_up:

Bundle name Size Change
app-webpack-bundle-array-push 28.7MB 47.07kB :arrow_up:

codecov[bot] avatar Aug 07 '24 23:08 codecov[bot]

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.24%. Comparing base (117cfb2) to head (df85efd). Report is 94 commits behind head on master.

:white_check_mark: All tests successful. No failed tests found.

Files Patch % Lines
...pp/views/alerts/rules/metric/thresholdTypeForm.tsx 50.00% 5 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #75793       +/-   ##
===========================================
+ Coverage   57.23%   78.24%   +21.00%     
===========================================
  Files        6807     6817       +10     
  Lines      303280   303652      +372     
  Branches    52176    52228       +52     
===========================================
+ Hits       173582   237587    +64005     
+ Misses     124900    59680    -65220     
- Partials     4798     6385     +1587     
Files Coverage Δ
src/sentry/features/temporary.py 100.00% <100.00%> (ø)
...c/app/views/alerts/rules/metric/triggers/index.tsx 68.18% <ø> (ø)
static/app/views/alerts/rules/metric/types.tsx 100.00% <ø> (ø)
...pp/views/alerts/rules/metric/thresholdTypeForm.tsx 61.11% <50.00%> (-3.60%) :arrow_down:

... and 2048 files with indirect coverage changes

codecov[bot] avatar Aug 08 '24 00:08 codecov[bot]