sentry icon indicating copy to clipboard operation
sentry copied to clipboard

Project Stats total is calculated incorrectly

Open dalnoki opened this issue 1 year ago • 5 comments

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Go to the Stats page, filter to show data for a single project that has a Spike Protection enabled
  2. Hover over a column
  3. The Spike Protection threshold is currently added to the total:

Image

Expected Result

the Spike Protection threshold should not be added to the total

Actual Result

the Spike Protection threshold is now added to the total

Product Area

Stats

Link

No response

DSN

No response

Version

No response

dalnoki avatar Jul 31 '24 07:07 dalnoki

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] avatar Jul 31 '24 07:07 getsantry[bot]

Routing to @getsentry/product-owners-stats for triage ⏲️

getsantry[bot] avatar Jul 31 '24 07:07 getsantry[bot]

Hi @dalnoki, the intention behind the stats page is to give customers visibility into the outcomes of all the events they send to Sentry. This helps customers understand why data might not be appearing in various product surfaces. Is there a reason why you don't believe these should show up? We already have the ability to filter out types of events by their outcome by clicking on the type of outcome on the top right of the chart.

brianthi avatar Aug 01 '24 15:08 brianthi

Hi @brianthi, I do not quite understand your reasoning. While all other types of issues shown in the screenshot are actual issue counts and should count towards the total (except "Error Message" which is included in "Filtered"), the "Spike Protection Threshold" is only a threshold.

As such a threshold, it represents an amount of issues over which X happens (in this case spike protection kicks in). It does not represent an amount of issues that were handled in one way or another in that timeframe. Considering this, I think it should not count toward the total count of issues.

Note: While the threshold itself should not count towards all issues, the issues that were discarded due to spike protection should. However, this then needs a separate listing (I presume it already has), since the threshold and the amount of discarded issues over this threshold are separate from one another.

maximilianruesch avatar Aug 01 '24 17:08 maximilianruesch

Hi @maximilianruesch, apologies, I misread the ticket. Agree with you that the threshold itself should not be added to the totals. Will get this into our backlog and will share in this ticket when we have an update.

brianthi avatar Aug 01 '24 21:08 brianthi