sentry icon indicating copy to clipboard operation
sentry copied to clipboard

fix(performance): Fix queues module empty state always displaying when an environment is selected

Open edwardgou-sentry opened this issue 9 months ago • 2 comments

Updates the useHasData to also query for transaction in order to force discover to use the non light exclusive_time metric. exclusive_time_light doesn't have an environment tag on the queues module, so this is a work around.

edwardgou-sentry avatar May 21 '24 19:05 edwardgou-sentry

Bundle Report

Changes will increase total bundle size by 14.87kB :arrow_up:

Bundle name Size Change
app-webpack-bundle-array-push 27.67MB 14.87kB :arrow_up:

codecov[bot] avatar May 21 '24 19:05 codecov[bot]

Nice, The light vs non light is super uninutitive imo, and we run into this situation a good amount.

We can probably add a comment here why we need transaction for the next person.

Also, I guess every metric you need is already tagged with environment then? That's why this issue is just showing up now?

yeah it's pretty easy to trip over this :(

I just went ahead and made the change in relay since it looks like it's also affecting other page elements: https://github.com/getsentry/relay/pull/3632

So gunna hold off on merging this for now

edwardgou-sentry avatar May 22 '24 12:05 edwardgou-sentry