sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(generic-metrics): Add dropped percentiles to aggregation options

Open ayirr7 opened this issue 9 months ago • 2 comments

Refactoring the way we used an older option for enabling 10s granularity so its purpose is clearer.

Enable org-level and use case-level of disabling percentiles using the newly created Sentry options.

ayirr7 avatar May 13 '24 22:05 ayirr7

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.92%. Comparing base (fea4348) to head (5626223). Report is 173 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70824      +/-   ##
==========================================
+ Coverage   77.87%   77.92%   +0.04%     
==========================================
  Files        6529     6525       -4     
  Lines      290909   290480     -429     
  Branches    50338    50254      -84     
==========================================
- Hits       226548   226348     -200     
+ Misses      58122    57874     -248     
- Partials     6239     6258      +19     
Files Coverage Δ
src/sentry/options/defaults.py 100.00% <100.00%> (ø)
...ntry/sentry_metrics/aggregation_option_registry.py 100.00% <100.00%> (ø)

... and 162 files with indirect coverage changes

codecov[bot] avatar May 13 '24 23:05 codecov[bot]

Will add more unit tests to check that the logic in get_aggregation_options is correct

ayirr7 avatar May 21 '24 14:05 ayirr7