sentry icon indicating copy to clipboard operation
sentry copied to clipboard

update: Querysubscription timebox delete column db operation

Open nhsiehgit opened this issue 1 year ago • 3 comments

requires https://github.com/getsentry/sentry/pull/70628

nhsiehgit avatar May 09 '24 23:05 nhsiehgit

This PR has a migration; here is the generated SQL for src/sentry/migrations/0718_delete_timebox_columns.py src/sentry/migrations/0719_querysubscription_timebox_column_deletion_db.py ()

--
-- Custom state/database change combination
--

                ALTER TABLE "sentry_querysubscription" DROP COLUMN "timebox_start";
                ALTER TABLE "sentry_querysubscription" DROP COLUMN "timebox_end";

github-actions[bot] avatar May 09 '24 23:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.04%. Comparing base (ae2b8a5) to head (304b988). Report is 1 commits behind head on master.

:exclamation: Current head 304b988 differs from pull request most recent head 7241c36. Consider uploading reports for the commit 7241c36 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #70630       +/-   ##
===========================================
+ Coverage   58.50%   80.04%   +21.53%     
===========================================
  Files        6496     6502        +6     
  Lines      290233   290534      +301     
  Branches    50023    50067       +44     
===========================================
+ Hits       169806   232544    +62738     
+ Misses     119985    57552    -62433     
+ Partials      442      438        -4     
Files Coverage Δ
src/sentry/snuba/models.py 100.00% <ø> (ø)

... and 1940 files with indirect coverage changes

codecov[bot] avatar May 10 '24 00:05 codecov[bot]

This PR has a migration; here is the generated SQL for src/sentry/migrations/0719_querysubscription_timebox_column_deletion_db.py ()

--
-- Custom state/database change combination
--

                ALTER TABLE "sentry_querysubscription" DROP COLUMN "timebox_start";
                ALTER TABLE "sentry_querysubscription" DROP COLUMN "timebox_end";

github-actions[bot] avatar May 10 '24 14:05 github-actions[bot]