sentry icon indicating copy to clipboard operation
sentry copied to clipboard

Suspect Commit discrepancies

Open armenzg opened this issue 1 year ago • 1 comments

The root of the problem is that somehow the Slack notifications and the UI are fetching the data differently.

The UI gets the list of committers from this API: https://us.sentry.io/api/0/projects/sentry/sentry/events/d6d5d807c0d9449d827e004623246900/committers/

@malwilley was one of the last people touching this area.

We would have to determine how the Slack alert gets the suspect commit.

Which suspect commit would have been the better pick?

If we load this issue we will see this suspect commit (https://github.com/getsentry/sentry/pull/69211 to PR): image

If we look at the alert we received in Slack we will see this suspect commit (link to PR): image

The stack trace is this: image

Yagiz's change is the suspect commit because base.py was recently changed from the stack trace, however, the change was from load_json_body rather than dispatch (which is part of the stack trace), thus, it should not have been considered a suspect commit:

From Yagiz's change: image This shows that the function dispatch is part of the stack trace: image

Snigdha's change does touch the put function from organization_group_index.py, thus, it makes more sense to blame it: image image

armenzg avatar May 09 '24 20:05 armenzg

Routing to @getsentry/product-owners-alerts for triage ⏲️

getsantry[bot] avatar May 10 '24 11:05 getsantry[bot]

Cathy's working on this in https://github.com/getsentry/sentry/pull/70634

ceorourke avatar May 10 '24 22:05 ceorourke

The suspect commit is processed async so it's not guaranteed to exist by the time the Slack notification is sent. I added logic to fetch it via GroupOwner if it exists

cathteng avatar May 14 '24 23:05 cathteng