sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(highlights): Error boundaries, styling fixes, empty states and add from tags

Open leeandher opened this issue 9 months ago • 1 comments

More features/fixes for highlights:

  • Error boundaries to prevent crashing the whole page if something goes wrong: Screenshot 2024-05-09 at 11 31 17 AM Screenshot 2024-05-09 at 12 15 10 PM Screenshot 2024-05-09 at 11 28 25 AM

  • Fixed height for edit highlights modal + empty states on context/tag search:

https://github.com/getsentry/sentry/assets/35509934/4f12b063-51b4-4233-a18e-9af9cda7c968

  • Highlights not present in the event no longer appear as links or with dropdowns image

  • You can add to highlights from the tag section image (and it's omitted when already present in highlights) image

  • Display meta annotations that aren't errors for tags image

todo

  • [x] Add tests
  • [x] Add screenshots/videos

leeandher avatar May 09 '24 18:05 leeandher

On second thought, I am going to avoid drilling the Project prop and maybe put together a context provider for detailed project, will re-open when that's implemented.

leeandher avatar May 09 '24 19:05 leeandher

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: useLocation() may be used only in the context of a <Router> component. useLocation(useLocation.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a <Router> component. useLocation(useLocation.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a <Router> component. useLocation(useLocation.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a <Router> component. useLocation(useLocation.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a <Router> component. useLocation(useLocation.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

sentry-io[bot] avatar May 15 '24 20:05 sentry-io[bot]