sentry
sentry copied to clipboard
feat(assignee-selector): Create storybook component for new assignee selector trigger
This PR creates a new component <AssigneeBadge/>
which will eventually replace the current assignee selector trigger in the issue stream. This PR does not make any changes to the selector, it merely creates the component and a corresponding storybook entry so it can be iterated on independent of any changes made to the issue stream.
More details of the project can be found here
At a glance (as of 5/9):
Note that unlike the previous assignee selector, there is no longer a "Suggested Assignee" state for this new assignee selector, there is only an Assigned and Unassigned state.
TODO:
- [x] Figure out what the loading state looks like
- [x] Chevron weight and style match border
- [ ] Add tests
does this still work for the suspect commit suggested assignee?
@roggenkemper If the issue has a suggested assignee because of a suspect commit, that suggestion will still be surfaced in the dropdown itself. However since there is no longer a suggested assignee state for this new trigger, we will no longer surface that information on hover like in this example from the current UI:
This is not 100% set in stone though, so we can discuss this further if you have strong opinions
maybe this is just me but i feel like the padding between the avatar and the name could be increased a bit
Updated designs:
Suspect Issues
This pull request was deployed and Sentry observed the following issues:
- ‼️ TypeError: Cannot read properties of undefined (reading 'id')
/stories/
View Issue
Did you find this useful? React with a 👍 or 👎