sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(perf): Update the Spans tab in Transaction Summary

Open 0Calories opened this issue 1 year ago • 1 comments

Upgrades the Spans tab on the transaction summary to query from the Span metrics dataset and changes the table to have columns more relevant to span metrics.

Before

image

After

image

TODO in followup PRs

  • [ ] Searchbar needs to be implemented (and not auto-suggest irrelevant transaction tags that don't work)
  • [ ] Operations filter should get its options from the spans metrics dataset instead of suspect spans

0Calories avatar May 06 '24 19:05 0Calories

Codecov Report

Attention: Patch coverage is 60.78431% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 77.86%. Comparing base (f1e0f4f) to head (9ae03c4). Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70373      +/-   ##
==========================================
- Coverage   77.86%   77.86%   -0.01%     
==========================================
  Files        6534     6536       +2     
  Lines      291150   291210      +60     
  Branches    50379    50383       +4     
==========================================
+ Hits       226695   226738      +43     
- Misses      58222    58239      +17     
  Partials     6233     6233              
Files Coverage Δ
...transactionSpans/spanSummary/spanSummaryCharts.tsx 0.00% <ø> (ø)
...transactionSpans/spanSummary/spanSummaryHeader.tsx 47.36% <ø> (ø)
.../starfish/components/tableCells/renderHeadCell.tsx 92.00% <100.00%> (ø)
...ctionSummary/transactionSpans/spanMetricsTable.tsx 96.00% <96.00%> (ø)
...onSummary/transactionSpans/spanSummary/content.tsx 0.00% <0.00%> (ø)
...nSummary/transactionSpans/useSpansTabTableSort.tsx 71.42% <71.42%> (ø)
...ce/transactionSummary/transactionSpans/content.tsx 53.33% <5.88%> (-18.76%) :arrow_down:

... and 6 files with indirect coverage changes

codecov[bot] avatar May 09 '24 19:05 codecov[bot]