sentry icon indicating copy to clipboard operation
sentry copied to clipboard

chore: Upgrade snuba-sdk to 2.0.26

Open iambriccardo opened this issue 1 year ago • 1 comments

iambriccardo avatar Feb 12 '24 13:02 iambriccardo

need to address the ci fails in getsentry/pypi#663

here's your root cause: https://github.com/getsentry/snuba-sdk/commit/b7a64da26d17987fd233351a4d37a883fd7fdd9d#r138544221

asottile-sentry avatar Feb 12 '24 19:02 asottile-sentry

here's your root cause: getsentry/snuba-sdk@b7a64da#r138544221

@asottile-sentry @joshuarli Why did this start breaking just for these last few builds? Parsimonious has been in the Snuba SDK for a long time. Seems weird that it would just now start breaking in PyPI.

Also, is there a way the Search team can get notified if these problems happen?

evanh avatar Feb 13 '24 15:02 evanh

here's your root cause: getsentry/snuba-sdk@b7a64da#r138544221

@asottile-sentry @joshuarli Why did this start breaking just for these last few builds? Parsimonious has been in the Snuba SDK for a long time. Seems weird that it would just now start breaking in PyPI.

Also, is there a way the Search team can get notified if these problems happen?

it just started breaking because of __init__.py shuffles

there isn't really a way to be notified that I know of -- the developer which added parsimonious was notified with a failure but picked the wrong fix breaking the package

asottile-sentry avatar Feb 13 '24 15:02 asottile-sentry

there isn't really a way to be notified that I know of -- the developer which added parsimonious was notified with a failure but picked the wrong fix breaking the package

What failure notification was this? Not sure what you mean.

evanh avatar Feb 13 '24 15:02 evanh

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (526b69c) 81.47% compared to head (eda669c) 81.46%. Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #64994      +/-   ##
==========================================
- Coverage   81.47%   81.46%   -0.01%     
==========================================
  Files        5255     5255              
  Lines      232112   232098      -14     
  Branches    45524    45521       -3     
==========================================
- Hits       189106   189090      -16     
- Misses      37127    37129       +2     
  Partials     5879     5879              
Files Coverage Δ
...c/sentry/sentry_metrics/querying/data/execution.py 89.78% <100.00%> (ø)
...entry/sentry_metrics/querying/data_v2/execution.py 75.67% <100.00%> (ø)
..._metrics/querying/metadata/metrics_correlations.py 70.91% <100.00%> (ø)
src/sentry/snuba/metrics_layer/query.py 86.64% <100.00%> (+0.50%) :arrow_up:
src/sentry/sentry_metrics/querying/data/parsing.py 94.20% <75.00%> (-0.09%) :arrow_down:
.../sentry/sentry_metrics/querying/data_v2/parsing.py 94.87% <75.00%> (-0.13%) :arrow_down:

... and 6 files with indirect coverage changes

codecov[bot] avatar Feb 14 '24 09:02 codecov[bot]

Depends on https://github.com/getsentry/snuba/pull/5525

evanh avatar Feb 14 '24 18:02 evanh

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AssertionError /api/0/organizations/{organization_slug}/metric... View Issue

Did you find this useful? React with a 👍 or 👎

sentry-io[bot] avatar Feb 21 '24 07:02 sentry-io[bot]