ref(grouping): Do final `_save_aggregate_new` cleanup tasks
This does a last batch of cleanup in _save_aggregate_new before the new logic is added.
Notes:
-
releaseis only used once, and can be pulled straight out ofjob, so it doesn't need to be passed separately. -
The logging about missing severity scores is leftover from the initial POC back in September, mostly just me being paranoid. We don't need it anymore.
-
I nearly took the second check of the double-check lock out before I realized what it was doing there. Fortunately Markus name-dropped double-entrant locking in his PR description when he put it in. Since it's not immediately obvious why it's there, I added some explanation.
-
The
metrics.timercontext manager'smetric_tagswas shadowing themetric_tagsbeing passed in. Fixing that will let us use the latter tags inrecord_new_group_metricsif we ever want to.