sentry icon indicating copy to clipboard operation
sentry copied to clipboard

[Epic] Replay Trace/Perf View: Better Connecting Replays to Transactions

Open jas-kas opened this issue 1 year ago • 2 comments

https://www.notion.so/FY-24-Q2-Trace-View-Better-Connecting-Replays-to-Transactions-b32f110233c145bbb5c963d4d692de07

Figma:

  • Exploring extensions to the existing trace view: https://www.figma.com/file/BkgpCdPfr9AreSIUZLRrWk/Specs%3A-Tracing-Waterfall-View?type=design&node-id=29-14271&mode=design&t=w38JI2CU6CcsK0F3-0

Related:

  • [x] https://github.com/getsentry/sentry/issues/37054

jas-kas avatar May 31 '23 15:05 jas-kas

First version implemented in https://github.com/getsentry/sentry/pull/54518

SCR-20230830-luxy

ryan953 avatar Aug 30 '23 21:08 ryan953

Update:

You may notice that we shipped something very different from what is in the figma.

I think though the new design solves all the problem statements which were identified in that figma, and in a simpler to understand way. What does it solve?

  1. Pending time index: we have a purple horizontal line that moves with the player, showing which crumb you’re before/after. Just like the other tabs do.
    (The old trace tab has a vertical purple line that tracks from left to right, following the player)
  2. Fast-forward or rewinding: We’ve got timestamps next to each breadcrumb to jump to specific times.
  3. Scrolling to catch up to a playing replay: We’re going to have the “back/more” buttons that catherine is building (https://github.com/getsentry/sentry/issues/52926) and since each waterfall is smaller in scope, each span is easier to see (more than 1px wide)
  4. Cause of a trace: easier to see beacuse we’re correlating traces to breadcrumbs (based on timestamp, it’s not perfect)
  5. Supertrace Duration != replay durtaion: There’s no more supertrace. The supertrace was really full of a lot of empty space. Instead we zoom in on each area where something is happening, and the spaces between are not shown

For the next milestone/iteration, there's still lots to do:

  • Add ability to click through to open Trace Details page, show the Event & Trace ID's
  • Each trace takes up 100% of the width, so it’s hard to spot that one trace is 5000ms, and another is 300ms. Explore using color to distingish slow/fast transactions?
  • There are more interesting filters to add to zoom in on the data:
    • find/exclude txn name
    • show txns that include a specific span
    • show txns above/below specific durations
  • expand/collapse spans
    • maybe even limit the number/depth of spans that we show
  • page render/performance improvements
    • could do more virtual rendering to better handle scrolling and large waterfalls

cc @Jesse-Box

ryan953 avatar Aug 31 '23 16:08 ryan953

This was done with @Abdkhan14 work on the new trace view in replay :)

jas-kas avatar Oct 24 '24 12:10 jas-kas