sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(replays): Replay Details header link to view errors in Console tab

Open ryan953 opened this issue 2 years ago • 3 comments

Depends on #39030

Fixes #38861

ryan953 avatar Sep 19 '22 21:09 ryan953

size-limit report 📦

Path Size
src/sentry/static/sentry/dist/entrypoints/app.js 20.4 KB (-0.02% 🔽)
src/sentry/static/sentry/dist/entrypoints/sentry.css 33.09 KB (0%)

github-actions[bot] avatar Sep 20 '22 01:09 github-actions[bot]

@ryan953 when you click the link in the header, does it also filter the console by all errors?

Jesse-Box avatar Sep 20 '22 07:09 Jesse-Box

when you click the link in the header, does it also filter the console by all errors?

@Jesse-Box yes, right now it's filtering to show all errors because we've got console.error and sentry-errors mixed together.

There's another ticket somewhere to make them two types of things, and at that time we can change the hard-coded f_c_logLevel: 'error', into f_c_logLevel: 'sentry-error', or whatever the new type is going to be called.

ryan953 avatar Sep 20 '22 16:09 ryan953

Found an issue with this: when there are no sentry errors clicking the link in the header will set the console filter, but 'error' isn't in the list, so it looks a bit broken.

ryan953 avatar Sep 21 '22 15:09 ryan953

when you click the link in the header, does it also filter the console by all errors?

@Jesse-Box yes, right now it's filtering to show all errors because we've got console.error and sentry-errors mixed together.

There's another ticket somewhere to make them two types of things, and at that time we can change the hard-coded f_c_logLevel: 'error', into f_c_logLevel: 'sentry-error', or whatever the new type is going to be called.

Nice, thanks for the replay

Jesse-Box avatar Sep 22 '22 07:09 Jesse-Box