sentry
sentry copied to clipboard
feat(triage signals): Add billing flag to all triage signals check
PR Details
- Replace direct
features.has("organizations:triage-signals-v0-org")checks withis_seer_seat_based_tier_enabled()across all triage signals code paths. - Already tested it out on s amller scale with this PR that just added it in 1 place: https://github.com/getsentry/sentry/pull/104528. Logs are here. No failure logs yet.
Changes
-
issue_summary.py: Updatedrun_automation()to useis_seer_seat_based_tier_enabled()for both the ALERT event count check and the stopping point logic -
similarity/utils.py: Updatedset_default_project_autofix_automation_tuning()andset_default_project_seer_scanner_automation()to useis_seer_seat_based_tier_enabled() -
post_process.py: Updatedkick_off_seer_automation()to useis_seer_seat_based_tier_enabled()
Why
The is_seer_seat_based_tier_enabled() function checks both:
- The existing
organizations:triage-signals-v0-orgfeature flag - The new
organizations:seat-based-seer-enabledbilling flag (with caching)
This allows triage signals features to work for organizations with either the feature flag OR the seat-based billing tier enabled.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## master #104570 +/- ##
===========================================
- Coverage 80.63% 80.52% -0.12%
===========================================
Files 9335 9330 -5
Lines 402949 400651 -2298
Branches 25689 25689
===========================================
- Hits 324921 322627 -2294
+ Misses 77562 77558 -4
Partials 466 466