sentry
sentry copied to clipboard
feat(tracemetrics): Add initial dataset implementation to dashboards
This begins adding the traceMetrics dataset to Dashboards. This is still a WIP and different aspects of Metrics in dashboards still need iteration before being feature complete and releasable.
The functionality captured here are:
- The dataset button appears
- When selecting the dataset, the visualize bars load the first metric and selects it, as well as auto-selects the first applicable aggregate
- Users can add more metrics to compare
- Users can filter metrics
- Users can add a group by
- Users can save and edit a widget
The functionality that needs to be iterated on (i.e. not complete in this PR) are:
- Decide how to restrict when users can query different metrics (e.g. filters across different metrics can't be applied the same way we do other datasets)
- Group by should be restricted to the metrics selected
- Order by should be automatically selected and set to the aggregate
- Adding an alias needs to work
- Handle starting state/empty state better before we've loaded metrics
- Fix bug with new timeseries visualization
- Implement confidence footer
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## master #104518 +/- ##
===========================================
- Coverage 80.51% 80.51% -0.01%
===========================================
Files 9347 9347
Lines 399873 399829 -44
Branches 25651 25639 -12
===========================================
- Hits 321962 321925 -37
+ Misses 77463 77456 -7
Partials 448 448