feat(cells): make email capture demo mode control-silo only
note: it is safe to ship frontend + backend together in this case as backend currently works in both silos
🚨 Warning: This pull request contains Frontend and Backend changes!
It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.
Have questions? Please ask in the #discuss-dev-infra channel.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## master #104488 +/- ##
===========================================
+ Coverage 80.53% 80.54% +0.01%
===========================================
Files 9350 9351 +1
Lines 400099 400614 +515
Branches 25660 25660
===========================================
+ Hits 322216 322687 +471
- Misses 77415 77459 +44
Partials 468 468
For my education, why is this safe? It'd seem that this restricts the endpoint to control and thus old UI code would be potentially broken until a new UI push, so we'd want to make sure the UI change goes out before the backend. Do we not limit by silo in the API this way? Or is "ui deploys first" a safe enough bet that it's not worth worrying about?
For my education, why is this safe? It'd seem that this restricts the endpoint to control and thus old UI code would be potentially broken until a new UI push, so we'd want to make sure the UI change goes out before the backend. Do we not limit by silo in the API this way? Or is "ui deploys first" a safe enough bet that it's not worth worrying about?
oh yeah you're right.. this does assume the UI goes out first. i think it's ok in this case -- the frontend control routes are generated from the backend change so it's kinda designed to go out together the backend was switched from region only -> all silos in a prior PR so i think it's ok for this non-critical API
so i think it's ok for this non-critical API
This was my thinking as well. The demo email intake is low enough that a deploy cycle will be fine here as the frontend will deploy well before the API servers will.