sentry icon indicating copy to clipboard operation
sentry copied to clipboard

fix(aci): Extend taint tracking to delayed workflow condition evaluation

Open kcons opened this issue 1 month ago • 1 comments

delayed_workflow can fail to evaluate snuba queries and as a result potentially trigger incorrectly. We already report this case, but only locally and without any reasonable way to assess the impact.

Extending the TriggerResult taint-tracking approach to delayed workflow condition evaluation allows us to start tracking at least in terms of if-condition evaluations how many results are tainted vs not, giving us something much more user-relevant to alert on.

This should be refined further to be reported in terms of workflows and/or actions, but that's a follow-up.

Updates ACI-563.

kcons avatar Dec 04 '25 00:12 kcons

Codecov Report

:x: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review. :white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...try/workflow_engine/processors/delayed_workflow.py 93.75% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #104368      +/-   ##
===========================================
+ Coverage   72.09%    80.40%   +8.30%     
===========================================
  Files        9388      9393       +5     
  Lines      403214    403531     +317     
  Branches    25991     25991              
===========================================
+ Hits       290699    324458   +33759     
+ Misses     112067     78625   -33442     
  Partials      448       448              

codecov[bot] avatar Dec 04 '25 00:12 codecov[bot]