sentry-xamarin icon indicating copy to clipboard operation
sentry-xamarin copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

Discuss CancelationToken on FormsApplicationListener

Open lucas-zimerman opened this issue 3 years ago • 1 comments

To not lose the comment from Matt

https://github.com/getsentry/sentry-xamarin/pull/108#pullrequestreview-932694614

Yikes. I see this was in the old code and you are just refactoring, but we really shouldn't completely lose this task. It should be saved somewhere. We should also register it for cancellation so it can be shut down gracefully. I'm OK if this is done in a future PR, but wanted to point it out.

On https://github.com/getsentry/sentry-xamarin/blob/6c15473b6ddaa10afc0274cd131cb2a612628361/Src/Sentry.Xamarin.Forms/Internals/FormsApplicationListener.cs#L30-L45

lucas-zimerman avatar Apr 06 '22 17:04 lucas-zimerman

Task.Run() should have the value assigned somewhere and the result/exception inspected, or at least a whole try/catch in the body handling any error (we should do this anyway). Also we could go with ContinuesWith(...)

bruno-garcia avatar Apr 19 '22 19:04 bruno-garcia

Xamarin is out of support by Microsoft. So while we're happy to take PRs here and get a new release out with fixes. We won't be making big investments here and instead invest on .NET Mobile and MAUI.

bruno-garcia avatar Dec 30 '24 22:12 bruno-garcia