sentry-wizard icon indicating copy to clipboard operation
sentry-wizard copied to clipboard

Fix(Cordova) enhanced node path detection, debug symbols now run in foreground.

Open lucas-zimerman opened this issue 1 year ago • 1 comments

This is a refactor on how the Cordova Integration runs, the main changes on the PR are:

  • More path options for sentry.properties.
  • Use the latest version of nvm node as a fallback if no node versions were found.
  • Skip the integration if node isn't found, avoiding a build failure when running Sentry-CLI.
  • Use a more modern approach to find where Sentry-CLI is located.
  • Run Sentry/CLI in foreground to help with debug information logs.

lucas-zimerman avatar Oct 22 '24 16:10 lucas-zimerman

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 27.69%. Comparing base (0e3a41a) to head (9f5c01d). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/Steps/Integrations/Cordova.ts 0.00% 23 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
- Coverage   27.72%   27.69%   -0.04%     
==========================================
  Files         129      129              
  Lines       13854    13871      +17     
  Branches      831      831              
==========================================
  Hits         3841     3841              
- Misses       9995    10012      +17     
  Partials       18       18              
Flag Coverage Δ
unit-tests 27.69% <0.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Feb 27 '25 18:02 codecov[bot]