Sentry Wizard fails to modify `Bundle React Native and images`

[thomasttvo]

Environment

Due to the older versions of Sentry not working with Hermes, we needed to modify Bundle React Native and images to support hermes, at which time we removed $REACT_NATIVE_XCODE from the build phase. The wizard for the latest version just performs a string replacement without checking whether the $REACT_NATIVE_XCODE is there, which reports false positive.

Steps to Reproduce

Run npx @sentry/wizard@latest -s -i reactNative

Expected Result

The wizard alerts us that it's unable to fix this build phase. It does that for metro config but not for Bundle React Native and images

Actual Result

The wizard reported that it was able to fix the build phase just fine ✅ , which is wrong

[Lms24]

Hey @thomasttvo thanks for writing in! Sounds like a reasonable expectation to me at first glance but I'm not deep enough into RN. Gonna tag @krystofwoldrich - would you mind taking a look please?

[krystofwoldrich]

This is still relevant, the wizard should fail if the $REACT_NATIVE_XCODE is not present and show a manual copy paste step.

[kahest]

@krystofwoldrich please give the linked PR another round of review so we can close this 🙏