sentry-wizard icon indicating copy to clipboard operation
sentry-wizard copied to clipboard

Update React Native Xcode build phase patch to avoid `react-native-version` crash

Open krystofwoldrich opened this issue 2 years ago • 0 comments

Although the current Xcode patch produces a perfectly valid shell script that is executed by Xcode, some third-party parses are crashing on this \" escape. We can change the script in a way to now use this particular sequence to avoid the parsing issue.

However, better would be to fix the parser itself. But the react-native-version was last updated 4 years ago.

  • Brought up in https://github.com/getsentry/sentry-react-native/issues/3625#issuecomment-1960298374
  • Original issue https://github.com/stovmascript/react-native-version/issues/327
  • Related patch https://github.com/getsentry/sentry-wizard/blob/5a5187647fc3f755b30c5044dfa60b15abd6b8ed/src/react-native/xcode.ts#L146 and https://github.com/getsentry/sentry-wizard/blob/5a5187647fc3f755b30c5044dfa60b15abd6b8ed/src/react-native/xcode.ts#L134

krystofwoldrich avatar Feb 23 '24 12:02 krystofwoldrich