sentry-wizard icon indicating copy to clipboard operation
sentry-wizard copied to clipboard

Sentry wizard overrides nvm configuration

Open troZee opened this issue 2 years ago • 7 comments

Environment

MacOS

Steps to Reproduce

  1. Install sentry wizard
  2. run nvm ls
  3. run nvm use 18.12.0
  4. run nvm current

Expected Result

sentry-wizard should not install node globally, which overrides nvm settings

Actual Result

If the node is installed, we should use the currently installed node.

➜  ~ brew uninstall node
Error: Refusing to uninstall /opt/homebrew/Cellar/node/21.3.0
because it is required by sentry-wizard, which is currently installed.
You can override this and force removal with:
  brew uninstall --ignore-dependencies node

After doing that

➜  ~ brew uninstall sentry-wizard 
Uninstalling /opt/homebrew/Cellar/sentry-wizard/3.19.0... (8,341 files, 47.8MB)
➜  ~ brew uninstall node         
Uninstalling /opt/homebrew/Cellar/node/21.3.0... (2,233 files, 63.5MB)
➜  ~ 

Everything works fine

troZee avatar Dec 15 '23 10:12 troZee

@romtsn I believe this is related to the brew target. Would you mind taking a look at this issue?

Lms24 avatar Dec 15 '23 16:12 Lms24

@Lms24 Sure, looks like we have to write a custom requirement that checks for an existing Node version and uses it, or otherwise installs the one from brew. The min supported Node version by the wizard is at 14.18 now, right?

romtsn avatar Dec 18 '23 14:12 romtsn

The min supported Node version by the wizard is at 14.18 now, right?

@romtsn yup. We might bump it in the future given Node 14 is EOL since a while but right now, it's >=1418.0.

Lms24 avatar Dec 18 '23 14:12 Lms24

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Jan 09 '24 00:01 github-actions[bot]