sentry-unity icon indicating copy to clipboard operation
sentry-unity copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

feat: scene-load transctions based on SceneManagerAPI

Open vaind opened this issue 2 years ago • 1 comments

See #235

This PR uses SceneManagerAPI which is only available in Unity 2020+

Samples: https://sentry.io/organizations/sentry-sdks/performance/summary/?project=5439417&query=transaction.duration%3A%3C15m&statsPeriod=24h&transaction=load-scene&unselectedSeries=p100%28%29

  • [x] move to SentryInitialization.cs (or use reflection?)
  • [ ] figure out if we can add the integration before the first scene starts loading

vaind avatar May 27 '22 14:05 vaind

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against ac193c131d025e0b7d8908f1c16d30f411f77388

github-actions[bot] avatar May 27 '22 14:05 github-actions[bot]

Maybe drop the "unity." prefix? Also, I've noticed the spans are missing names - what's the best practice in other SDKs?

https://sentry.io/organizations/sentry-sdks/performance/sentry-unity:4e44bacb819a4509ac4bb20b2c53d154/?project=5439417&query=transaction.duration%3A%3C15m&statsPeriod=30d&transaction=unity.runtime.startup&unselectedSeries=p100%28%29 image

image

Thanks for pointing that out.

Initially, I was a bit confused about the naming/description/operation of transactions and spans but the team came up with a scheme I think we can go with for now.

bitsandfoxes avatar Sep 29 '22 16:09 bitsandfoxes