sentry-unity icon indicating copy to clipboard operation
sentry-unity copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

Danger shouldnt require PR link: Automation appends link

Open bruno-garcia opened this issue 4 years ago • 1 comments
trafficstars

Danger should validate an entry exists in the changelog but not require the PR number to be added.

Danger when running could add the PR number (i.e: #123) to the changelog entry.

This way our workflow can change from:

  • pushing a branch
  • opening a PR
  • getting nagged by danger for a missing changelog entry
  • add changelog with PR number

To:

  • pushing a branch with a changelog entry missing the PR number
  • opening a PR (or gh pr create --fill)

An automation that runs once the branch is merged to main will append the PR number to the line (and avoid running CI on anything since only CHANGELOG will change)

An evolution from: https://github.com/getsentry/sentry-unity/issues/155

bruno-garcia avatar May 11 '21 18:05 bruno-garcia