sentry-ruby icon indicating copy to clipboard operation
sentry-ruby copied to clipboard

Ignore Sidekiq::JobRetry::Handled exception

Open karlentwistle opened this issue 1 year ago • 2 comments

Adds Sidekiq::JobRetry::Handled exception to default Sidekiq ignore list.

Sidekiq::JobRetry::Skip exceptions are currently ignored, however, since Sidekiq 7.3.0 shipped, I think Sidekiq::JobRetry::Handled exceptions also need to be ignored.

You can see the full diff between 7.2.4..7.3.0 and I'd particularly like to draw your attention to the changes within lib/sidekiq/job_retry.rb.

You can see in certain scenarios Sidekiq now raises Sidekiq::JobRetry::Handled (7.3.0) instead of Sidekiq::JobRetry::Skip (7.2.4).

Without this change, some customers will see the following in their Sentry Issues after upgrading to Sidekiq 7.3.0.

Screenshot 2024-07-03 at 08 27 40

karlentwistle avatar Jul 03 '24 07:07 karlentwistle

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.09%. Comparing base (ee37a4a) to head (a38b9f3). Report is 36 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2337   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         126      126           
  Lines        4723     4723           
=======================================
  Hits         4633     4633           
  Misses         90       90           
Components Coverage Δ
sentry-ruby 98.51% <ø> (ø)
sentry-rails 97.19% <ø> (ø)
sentry-sidekiq 95.45% <100.00%> (ø)
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-sidekiq/lib/sentry/sidekiq/configuration.rb 100.00% <100.00%> (ø)

codecov[bot] avatar Jul 03 '24 07:07 codecov[bot]

+1. I have a bunch of these in my Sentry as well, and they're always next to a second error event that's the actual problem. They can be safely ignored.

natematykiewicz avatar Oct 15 '24 21:10 natematykiewicz