sentry-ruby icon indicating copy to clipboard operation
sentry-ruby copied to clipboard

Drop `Gem::Specification`'s usage so it doesn't break bundler standalone

Open st0012 opened this issue 1 year ago • 2 comments

Fixes #2329

I also needed to bump sqlite3 because v1.6.9 doesn't run on Ruby 3.3, which is what I use in development.

st0012 avatar Jul 02 '24 11:07 st0012

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.67%. Comparing base (069de02) to head (2f4e174).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2335      +/-   ##
==========================================
+ Coverage   98.66%   98.67%   +0.01%     
==========================================
  Files         205      205              
  Lines       13481    13479       -2     
==========================================
  Hits        13301    13301              
+ Misses        180      178       -2     
Components Coverage Δ
sentry-ruby 99.04% <ø> (+0.01%) :arrow_up:
sentry-rails 97.41% <100.00%> (-0.01%) :arrow_down:
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 97.11% <ø> (+0.32%) :arrow_up:
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
...b/sentry/rails/tracing/active_record_subscriber.rb 90.19% <100.00%> (-0.37%) :arrow_down:

... and 2 files with indirect coverage changes

codecov[bot] avatar Jul 02 '24 11:07 codecov[bot]

@sl0thentr0py working with older Rubies, especially those <= 2.5, has been increasingly frustrating. Is there any plan to ditch support for them?

st0012 avatar Jul 02 '24 11:07 st0012

We can do it in the major, maybe I should do the major soon with dropping async and related stuff. The large hub refactor is postponed for now.

sl0thentr0py avatar Jul 02 '24 11:07 sl0thentr0py

We can do it in the major, maybe I should do the major soon with dropping async and related stuff.

FWIW, dropping a dependency/language version isn't usually considered a breaking change because in that case, the user simply won't install that version onwards.

st0012 avatar Jul 02 '24 11:07 st0012

I've had all kinds of problems in CI etc because someone dropped language support in a minor, just cleaner to do it in a major

sl0thentr0py avatar Jul 02 '24 12:07 sl0thentr0py