sentry-ruby icon indicating copy to clipboard operation
sentry-ruby copied to clipboard

Remove `config.capture_exception_frame_locals`

Open st0012 opened this issue 1 year ago • 1 comments

It's been marked as deprecated for a while now and should be removed in the next major release.

Additional note: some TracePoint events can invalidate YJIT's optimization, which was a main concern of the current implementation around locals capturing. But at least until Ruby 3.3, the raise event we're using is NOT one of them.

st0012 avatar May 06 '24 18:05 st0012

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (6.0-dev@7d86bb2). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             6.0-dev    #2306   +/-   ##
==========================================
  Coverage           ?   98.66%           
==========================================
  Files              ?      201           
  Lines              ?    13075           
  Branches           ?        0           
==========================================
  Hits               ?    12901           
  Misses             ?      174           
  Partials           ?        0           
Components Coverage Δ
sentry-ruby 99.05% <0.00%> (?)
sentry-rails 97.26% <0.00%> (?)
sentry-sidekiq 96.98% <0.00%> (?)
sentry-resque 96.76% <0.00%> (?)
sentry-delayed_job 98.91% <0.00%> (?)
sentry-opentelemetry 100.00% <0.00%> (?)
Files Coverage Δ
sentry-rails/spec/dummy/test_rails_app/app.rb 92.64% <100.00%> (ø)
sentry-ruby/lib/sentry/configuration.rb 98.75% <ø> (ø)
sentry-ruby/spec/sentry/configuration_spec.rb 100.00% <ø> (ø)

codecov[bot] avatar May 06 '24 18:05 codecov[bot]