sentry-ruby icon indicating copy to clipboard operation
sentry-ruby copied to clipboard

Send trace origin

Open stephanie-anderson opened this issue 2 years ago • 3 comments

See https://github.com/getsentry/team-sdks/issues/14

stephanie-anderson avatar Jul 12 '23 14:07 stephanie-anderson

Reference implementation in JS SDK: https://github.com/getsentry/sentry-javascript/pull/8765/files#diff-5d0f3b11ab97c0b33599238bf8fd5d242e334bbe1f625612ab2595011c0a3c19

@st0012, @sl0thentr0py, tracing noob here. Do you think we should set origin into a Transaction, or at a Span level?

If we go with Spans:

  • Add Span.origin attr. Make sure it's serialized correctly. Default to parent_span.origin, or manual, if there's no parent span.
  • Then once that's done — we'll go over integrations that make spans and add origins to each of those invocations.

Right? What am I missing?

natikgadzhi avatar Nov 24 '23 03:11 natikgadzhi

yes that's fine (on the span)

sl0thentr0py avatar Nov 27 '23 13:11 sl0thentr0py

Alright, I'll work on this next once I get my open PRs sorted out, unless you beat me to it.

natikgadzhi avatar Nov 30 '23 05:11 natikgadzhi