sentry-react-native
sentry-react-native copied to clipboard
chore: Move from using Hybrid SDK subspec to regular Sentry podspec
:loudspeaker: Type of change
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
:scroll: Description
Replaced the HybridSDK subspec with the regular one.
:bulb: Motivation and Context
Simplify our maintenance work
:green_heart: How did you test it?
:pencil: Checklist
- [ ] I added tests to verify changes
- [ ] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled - [ ] I updated the docs if needed.
- [ ] I updated the wizard if needed.
- [ ] All tests passing
- [ ] No breaking changes
:crystal_ball: Next steps
| Fails | |
|---|---|
| :no_entry_sign: | Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request |
Generated by :no_entry_sign: dangerJS against 09fa6d19e73b8d0eb17d8a1ffeb481886f1b789c
Android (legacy) Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 402.58 ms | 487.05 ms | 84.46 ms |
| Size | 43.75 MiB | 48.07 MiB | 4.32 MiB |
Android (new) Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 403.53 ms | 391.39 ms | -12.14 ms |
| Size | 43.94 MiB | 48.90 MiB | 4.96 MiB |
@antonis we have merged this on sentry-cocoa We still haven't released it, but these should be the only changes required on RN
Thank you for the heads up @itaybre and for keeping RN in sync 🙇 I'll test this out.