sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

chore(deps): update Cocoa SDK to v9

Open antonis opened this issue 1 month ago • 10 comments

:loudspeaker: Type of change

  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement
  • [ ] Refactoring

:scroll: Description

Breaking changes:

  • ⚠️ iOS 15.0, macOS 12.0
  • More: https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#breaking-changes

SubPRs:

  • https://github.com/getsentry/sentry-react-native/pull/5153
  • https://github.com/getsentry/sentry-react-native/pull/5267
  • https://github.com/getsentry/sentry-react-native/pull/5276
  • https://github.com/getsentry/sentry-react-native/pull/5359
  • https://github.com/getsentry/sentry-react-native/pull/5369

:bulb: Motivation and Context

See https://github.com/getsentry/sentry-react-native/issues/5273

:green_heart: How did you test it?

CI, Manual

:pencil: Checklist

  • [ ] I added tests to verify changes
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • [ ] I updated the docs if needed.
  • [ ] I updated the wizard if needed.
  • [ ] All tests passing
  • [ ] No breaking changes

:crystal_ball: Next steps

antonis avatar Nov 11 '25 10:11 antonis

Marking as Blocked while the Cocoa v9 is in Alpha

antonis avatar Nov 11 '25 14:11 antonis

Adding the ready-to-merge label to trigger all tests but it's not really ready to merge 😅

antonis avatar Nov 11 '25 15:11 antonis

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 369.06 ms 386.56 ms 17.50 ms
Size 43.94 MiB 48.91 MiB 4.97 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ad27f6e049040bb555a05c91c3fa12d7d7c40ddb+dirty 484.67 ms 532.79 ms 48.12 ms
f081f5835824c751e62cbe8c39fff082bf09fb0f+dirty 468.47 ms 492.64 ms 24.17 ms
294387d958295074cf443477b6bc12030b0dafcd+dirty 359.44 ms 393.40 ms 33.97 ms
c08359e632067bc9830d82f1946400d7c4f6d337+dirty 406.04 ms 428.87 ms 22.83 ms
e07935dd4746b652d1ade0a9f7fb693f0971e1cb+dirty 380.10 ms 377.48 ms -2.62 ms
9b50d327b0e195bd7bdd9ac3125fefbb7756fb23+dirty 429.59 ms 423.89 ms -5.70 ms
3099014ce3f4d2bfb33010045da7b6f78158cb8f+dirty 344.58 ms 404.21 ms 59.63 ms
eec00c23d3ac8bec8d0f7c86634365cbcb6d95ef+dirty 367.00 ms 392.12 ms 25.12 ms
a31630cb8451580d2d68ac8d8b4f155e4e2a0032+dirty 359.89 ms 416.90 ms 57.00 ms
e335046ea7778f93f8b1c99245da3a19ea1226d7+dirty 375.75 ms 392.85 ms 17.10 ms

App size

Revision Plain With Sentry Diff
ad27f6e049040bb555a05c91c3fa12d7d7c40ddb+dirty 43.94 MiB 48.90 MiB 4.96 MiB
f081f5835824c751e62cbe8c39fff082bf09fb0f+dirty 43.94 MiB 48.82 MiB 4.88 MiB
294387d958295074cf443477b6bc12030b0dafcd+dirty 43.94 MiB 48.87 MiB 4.93 MiB
c08359e632067bc9830d82f1946400d7c4f6d337+dirty 7.15 MiB 8.42 MiB 1.27 MiB
e07935dd4746b652d1ade0a9f7fb693f0971e1cb+dirty 43.94 MiB 48.82 MiB 4.88 MiB
9b50d327b0e195bd7bdd9ac3125fefbb7756fb23+dirty 43.94 MiB 48.87 MiB 4.93 MiB
3099014ce3f4d2bfb33010045da7b6f78158cb8f+dirty 7.15 MiB 8.43 MiB 1.27 MiB
eec00c23d3ac8bec8d0f7c86634365cbcb6d95ef+dirty 43.94 MiB 48.87 MiB 4.93 MiB
a31630cb8451580d2d68ac8d8b4f155e4e2a0032+dirty 7.15 MiB 8.41 MiB 1.26 MiB
e335046ea7778f93f8b1c99245da3a19ea1226d7+dirty 43.94 MiB 48.87 MiB 4.93 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
0816bdc6044ab329ea79ab3a30bb8ddc60893af9+dirty 576.86 ms 619.67 ms 42.81 ms
326e1a787faf3f8451a1d2bb2a33d12c6341f852+dirty 425.27 ms 425.81 ms 0.54 ms
9aa9f9b3e27ac4bd2e31bb125efbea5e6c39b62f+dirty 597.51 ms 634.22 ms 36.71 ms

App size

Revision Plain With Sentry Diff
0816bdc6044ab329ea79ab3a30bb8ddc60893af9+dirty 43.94 MiB 48.90 MiB 4.96 MiB
326e1a787faf3f8451a1d2bb2a33d12c6341f852+dirty 43.94 MiB 48.90 MiB 4.96 MiB
9aa9f9b3e27ac4bd2e31bb125efbea5e6c39b62f+dirty 43.94 MiB 48.90 MiB 4.96 MiB

github-actions[bot] avatar Nov 11 '25 16:11 github-actions[bot]

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 405.30 ms 422.77 ms 17.46 ms
Size 43.75 MiB 48.08 MiB 4.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
083f560c367e99fa4dfa95d7499a8e4b98425c29+dirty 358.21 ms 382.00 ms 23.79 ms
ad27f6e049040bb555a05c91c3fa12d7d7c40ddb+dirty 471.44 ms 516.23 ms 44.79 ms
f081f5835824c751e62cbe8c39fff082bf09fb0f+dirty 443.98 ms 480.26 ms 36.28 ms
d916aa34b63da8106b7fb7935c61c11508d19fbd 425.37 ms 427.02 ms 1.65 ms
294387d958295074cf443477b6bc12030b0dafcd+dirty 424.30 ms 465.40 ms 41.10 ms
90afdd35f819c4dc65e89211964cf6052c5d3092+dirty 375.94 ms 377.52 ms 1.58 ms
e07935dd4746b652d1ade0a9f7fb693f0971e1cb+dirty 448.82 ms 489.10 ms 40.29 ms
9b50d327b0e195bd7bdd9ac3125fefbb7756fb23+dirty 455.51 ms 466.56 ms 11.05 ms
eec00c23d3ac8bec8d0f7c86634365cbcb6d95ef+dirty 447.08 ms 469.04 ms 21.96 ms
46bd012f1ce48967586517dd84277a60b74715c9 387.09 ms 404.47 ms 17.38 ms

App size

Revision Plain With Sentry Diff
083f560c367e99fa4dfa95d7499a8e4b98425c29+dirty 17.75 MiB 19.70 MiB 1.96 MiB
ad27f6e049040bb555a05c91c3fa12d7d7c40ddb+dirty 43.75 MiB 48.07 MiB 4.32 MiB
f081f5835824c751e62cbe8c39fff082bf09fb0f+dirty 43.75 MiB 47.99 MiB 4.24 MiB
d916aa34b63da8106b7fb7935c61c11508d19fbd 17.75 MiB 20.15 MiB 2.41 MiB
294387d958295074cf443477b6bc12030b0dafcd+dirty 43.75 MiB 48.04 MiB 4.29 MiB
90afdd35f819c4dc65e89211964cf6052c5d3092+dirty 17.75 MiB 19.70 MiB 1.95 MiB
e07935dd4746b652d1ade0a9f7fb693f0971e1cb+dirty 43.75 MiB 47.99 MiB 4.24 MiB
9b50d327b0e195bd7bdd9ac3125fefbb7756fb23+dirty 43.75 MiB 48.04 MiB 4.29 MiB
eec00c23d3ac8bec8d0f7c86634365cbcb6d95ef+dirty 43.75 MiB 48.05 MiB 4.29 MiB
46bd012f1ce48967586517dd84277a60b74715c9 17.75 MiB 20.15 MiB 2.41 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
0816bdc6044ab329ea79ab3a30bb8ddc60893af9+dirty 420.64 ms 447.37 ms 26.73 ms
326e1a787faf3f8451a1d2bb2a33d12c6341f852+dirty 426.45 ms 457.84 ms 31.39 ms
9aa9f9b3e27ac4bd2e31bb125efbea5e6c39b62f+dirty 464.02 ms 490.62 ms 26.60 ms

App size

Revision Plain With Sentry Diff
0816bdc6044ab329ea79ab3a30bb8ddc60893af9+dirty 43.75 MiB 48.07 MiB 4.32 MiB
326e1a787faf3f8451a1d2bb2a33d12c6341f852+dirty 43.75 MiB 48.07 MiB 4.32 MiB
9aa9f9b3e27ac4bd2e31bb125efbea5e6c39b62f+dirty 43.75 MiB 48.07 MiB 4.32 MiB

github-actions[bot] avatar Nov 11 '25 16:11 github-actions[bot]

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1220.00 ms 1217.90 ms -2.10 ms
Size 3.44 MiB 4.74 MiB 1.31 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
000da7ab05cb7b77798b7caa14e19838b05dc602+dirty 1204.50 ms 1218.94 ms 14.44 ms
d1bfbde7c7071cfd8b8c3ab7a1b5dc1c99ad5e16+dirty 1221.30 ms 1218.70 ms -2.60 ms
59f3a84db64e1e6719c9667c77deca4ff769440f+dirty 1205.09 ms 1213.31 ms 8.23 ms
56914305118a7e65c0ae884d2c3a9fc12882acc0+dirty 1191.06 ms 1189.13 ms -1.94 ms
c4e097a08b8293f3189775e4b194971cf9f6d650+dirty 1231.35 ms 1246.91 ms 15.56 ms
652f7854736d5fe2f23d2abf1f5852af5c0012db+dirty 1216.42 ms 1212.21 ms -4.21 ms
88890fea5730e9330be8656121da6a8edb0e8143+dirty 1219.00 ms 1222.08 ms 3.08 ms
f081f5835824c751e62cbe8c39fff082bf09fb0f+dirty 1208.37 ms 1215.56 ms 7.19 ms
276d3480dffd5765c64e7574f62984a72fe88985+dirty 1222.10 ms 1229.02 ms 6.92 ms
ee69ed59ca69688de0c578f0c6521271292b54f2+dirty 1212.78 ms 1214.91 ms 2.13 ms

App size

Revision Plain With Sentry Diff
000da7ab05cb7b77798b7caa14e19838b05dc602+dirty 3.19 MiB 4.48 MiB 1.29 MiB
d1bfbde7c7071cfd8b8c3ab7a1b5dc1c99ad5e16+dirty 3.41 MiB 4.58 MiB 1.17 MiB
59f3a84db64e1e6719c9667c77deca4ff769440f+dirty 3.19 MiB 4.56 MiB 1.37 MiB
56914305118a7e65c0ae884d2c3a9fc12882acc0+dirty 3.41 MiB 4.59 MiB 1.18 MiB
c4e097a08b8293f3189775e4b194971cf9f6d650+dirty 3.19 MiB 4.44 MiB 1.25 MiB
652f7854736d5fe2f23d2abf1f5852af5c0012db+dirty 3.41 MiB 4.57 MiB 1.16 MiB
88890fea5730e9330be8656121da6a8edb0e8143+dirty 3.19 MiB 4.57 MiB 1.38 MiB
f081f5835824c751e62cbe8c39fff082bf09fb0f+dirty 3.41 MiB 4.58 MiB 1.17 MiB
276d3480dffd5765c64e7574f62984a72fe88985+dirty 3.19 MiB 4.54 MiB 1.36 MiB
ee69ed59ca69688de0c578f0c6521271292b54f2+dirty 3.41 MiB 4.59 MiB 1.18 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
9aa9f9b3e27ac4bd2e31bb125efbea5e6c39b62f+dirty 1217.00 ms 1212.65 ms -4.35 ms
0816bdc6044ab329ea79ab3a30bb8ddc60893af9+dirty 1207.15 ms 1214.24 ms 7.10 ms
326e1a787faf3f8451a1d2bb2a33d12c6341f852+dirty 1188.46 ms 1201.64 ms 13.18 ms

App size

Revision Plain With Sentry Diff
9aa9f9b3e27ac4bd2e31bb125efbea5e6c39b62f+dirty 3.41 MiB 4.74 MiB 1.33 MiB
0816bdc6044ab329ea79ab3a30bb8ddc60893af9+dirty 3.44 MiB 4.74 MiB 1.30 MiB
326e1a787faf3f8451a1d2bb2a33d12c6341f852+dirty 3.41 MiB 4.74 MiB 1.33 MiB

github-actions[bot] avatar Nov 11 '25 16:11 github-actions[bot]

iOS (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1188.04 ms 1198.19 ms 10.15 ms
Size 3.44 MiB 4.74 MiB 1.31 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
000da7ab05cb7b77798b7caa14e19838b05dc602+dirty 1214.31 ms 1221.91 ms 7.61 ms
d1bfbde7c7071cfd8b8c3ab7a1b5dc1c99ad5e16+dirty 1216.83 ms 1212.83 ms -3.99 ms
59f3a84db64e1e6719c9667c77deca4ff769440f+dirty 1232.56 ms 1238.12 ms 5.56 ms
56914305118a7e65c0ae884d2c3a9fc12882acc0+dirty 1218.89 ms 1222.22 ms 3.33 ms
c4e097a08b8293f3189775e4b194971cf9f6d650+dirty 1229.09 ms 1242.61 ms 13.53 ms
652f7854736d5fe2f23d2abf1f5852af5c0012db+dirty 1219.66 ms 1223.62 ms 3.96 ms
88890fea5730e9330be8656121da6a8edb0e8143+dirty 1219.20 ms 1231.00 ms 11.80 ms
f081f5835824c751e62cbe8c39fff082bf09fb0f+dirty 1219.10 ms 1217.57 ms -1.53 ms
276d3480dffd5765c64e7574f62984a72fe88985+dirty 1224.22 ms 1227.38 ms 3.16 ms
ee69ed59ca69688de0c578f0c6521271292b54f2+dirty 1206.79 ms 1213.98 ms 7.19 ms

App size

Revision Plain With Sentry Diff
000da7ab05cb7b77798b7caa14e19838b05dc602+dirty 2.63 MiB 3.91 MiB 1.28 MiB
d1bfbde7c7071cfd8b8c3ab7a1b5dc1c99ad5e16+dirty 3.41 MiB 4.58 MiB 1.17 MiB
59f3a84db64e1e6719c9667c77deca4ff769440f+dirty 2.63 MiB 3.99 MiB 1.36 MiB
56914305118a7e65c0ae884d2c3a9fc12882acc0+dirty 3.41 MiB 4.59 MiB 1.18 MiB
c4e097a08b8293f3189775e4b194971cf9f6d650+dirty 2.63 MiB 3.87 MiB 1.24 MiB
652f7854736d5fe2f23d2abf1f5852af5c0012db+dirty 3.41 MiB 4.57 MiB 1.16 MiB
88890fea5730e9330be8656121da6a8edb0e8143+dirty 2.63 MiB 4.00 MiB 1.37 MiB
f081f5835824c751e62cbe8c39fff082bf09fb0f+dirty 3.41 MiB 4.58 MiB 1.17 MiB
276d3480dffd5765c64e7574f62984a72fe88985+dirty 2.63 MiB 3.98 MiB 1.34 MiB
ee69ed59ca69688de0c578f0c6521271292b54f2+dirty 3.41 MiB 4.59 MiB 1.18 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
9aa9f9b3e27ac4bd2e31bb125efbea5e6c39b62f+dirty 1216.96 ms 1214.32 ms -2.64 ms
0816bdc6044ab329ea79ab3a30bb8ddc60893af9+dirty 1223.46 ms 1221.28 ms -2.18 ms
326e1a787faf3f8451a1d2bb2a33d12c6341f852+dirty 1210.09 ms 1217.29 ms 7.20 ms

App size

Revision Plain With Sentry Diff
9aa9f9b3e27ac4bd2e31bb125efbea5e6c39b62f+dirty 3.41 MiB 4.74 MiB 1.33 MiB
0816bdc6044ab329ea79ab3a30bb8ddc60893af9+dirty 3.44 MiB 4.74 MiB 1.30 MiB
326e1a787faf3f8451a1d2bb2a33d12c6341f852+dirty 3.41 MiB 4.74 MiB 1.33 MiB

github-actions[bot] avatar Nov 11 '25 16:11 github-actions[bot]

fix(podspec): Cocoa V9 allow any alpha version

Thank you @philipphofmann 🦸

antonis avatar Nov 13 '25 09:11 antonis

V9 was released so I will unblock this issue

lucas-zimerman avatar Dec 02 '25 19:12 lucas-zimerman

V9 was released so I will unblock this issue

Correct. I'll keep it in draft for now since we are not going to merge on the main branch but on v8.

I've also opened https://github.com/getsentry/sentry-cocoa/pull/6942 that I hope is going to fix some of the issues

antonis avatar Dec 03 '25 08:12 antonis

The CI is 🟢 again with 9.1.0 and the current issues are solved. The sample app also behaved as expected in my manual tests 🎉

antonis avatar Dec 11 '25 17:12 antonis