sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard
verified publisher icon getsentry

WIP: Merge main/v7 in Capture App Start Errors feature branch

Open antonis opened this issue 2 months ago • 2 comments

:loudspeaker: Type of change

  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement
  • [ ] Refactoring

Based on: https://github.com/getsentry/sentry-react-native/pull/4472

:scroll: Description

⚠️ TODO fix conflicts in packages/core/ios/RNSentry.mm and move the newly added functionality to packages/core/ios/RNSentryStart.m following the refactoring in https://github.com/getsentry/sentry-react-native/pull/4472

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I added tests to verify changes
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • [ ] I updated the docs if needed.
  • [ ] I updated the wizard if needed.
  • [ ] All tests passing
  • [ ] No breaking changes

:crystal_ball: Next steps

#skip-changelog

antonis avatar Oct 22 '25 16:10 antonis

due to the age of this PR, wouldn't it be better to start from a fresh branch and migrate the required changes for it?

lucas-zimerman avatar Oct 31 '25 11:10 lucas-zimerman

due to the age of this PR, wouldn't it be better to start from a fresh branch and migrate the required changes for it?

Yes, I'm trying that approach 😓 A lot of things have move around with v7 and there are changes in native code too that make a merge difficult.

antonis avatar Oct 31 '25 12:10 antonis

closing this PR in favour of https://github.com/getsentry/sentry-react-native/pull/5470

antonis avatar Dec 15 '25 13:12 antonis