sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

(WIP): ignoreErrors now works on Native

Open lucas-zimerman opened this issue 5 months ago • 5 comments

:loudspeaker: Type of change

  • [x] Bugfix
  • [ ] New feature
  • [ ] Enhancement
  • [ ] Refactoring

:scroll: Description

Before this change, ignoreErrors was only applied to JavaScript errors. With this PR, Native errors will also be able to be filtered by ignoreErrors.

:bulb: Motivation and Context

Fixes https://github.com/getsentry/sentry-react-native/issues/4924

:green_heart: How did you test it?

Unit Tests, sample app

:pencil: Checklist

  • [x] I added tests to verify changes
  • [x] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • [ ] I updated the docs if needed.
  • [x] I updated the wizard if needed.
  • [ ] All tests passing
  • [x] No breaking changes

:crystal_ball: Next steps

  • Document ignoreErrors on V7

lucas-zimerman avatar Jun 25 '25 14:06 lucas-zimerman

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 424.37 ms 420.47 ms -3.90 ms
Size 17.75 MiB 19.60 MiB 1.85 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
472960b07b4e7755510707a1204dc75cd3643423 418.84 ms 405.38 ms -13.46 ms
3c99746b6d73d4c5cf56b537d63f44e4e4e06b46 399.51 ms 429.09 ms 29.58 ms
f870f2d847a00dca3fcf079449beaefce22e9315 444.67 ms 449.62 ms 4.95 ms
7eff2d75fa6c1b6600312b339a907ec2b33c93eb 420.64 ms 401.86 ms -18.78 ms

App size

Revision Plain With Sentry Diff
472960b07b4e7755510707a1204dc75cd3643423 17.75 MiB 19.58 MiB 1.83 MiB
3c99746b6d73d4c5cf56b537d63f44e4e4e06b46 17.75 MiB 19.58 MiB 1.83 MiB
f870f2d847a00dca3fcf079449beaefce22e9315 17.75 MiB 19.58 MiB 1.83 MiB
7eff2d75fa6c1b6600312b339a907ec2b33c93eb 17.75 MiB 19.60 MiB 1.85 MiB

Previous results on branch: lz/v7/ignore-errors

Startup times

Revision Plain With Sentry Diff
000340c45cab7a6e7fd89ef8c7e05c106e42e0ed 449.20 ms 441.02 ms -8.18 ms
628a49042460c731369210efdcb29827d251b098 413.69 ms 399.41 ms -14.27 ms

App size

Revision Plain With Sentry Diff
000340c45cab7a6e7fd89ef8c7e05c106e42e0ed 17.75 MiB 19.60 MiB 1.85 MiB
628a49042460c731369210efdcb29827d251b098 17.75 MiB 19.60 MiB 1.85 MiB

github-actions[bot] avatar Jun 25 '25 15:06 github-actions[bot]

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 418.38 ms 410.18 ms -8.20 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
3c99746b6d73d4c5cf56b537d63f44e4e4e06b46+dirty 400.65 ms 399.59 ms -1.06 ms
7eff2d75fa6c1b6600312b339a907ec2b33c93eb+dirty 393.13 ms 426.77 ms 33.65 ms
472960b07b4e7755510707a1204dc75cd3643423+dirty 394.39 ms 376.18 ms -18.20 ms
f870f2d847a00dca3fcf079449beaefce22e9315+dirty 398.49 ms 434.24 ms 35.75 ms

App size

Revision Plain With Sentry Diff
3c99746b6d73d4c5cf56b537d63f44e4e4e06b46+dirty 7.15 MiB 8.34 MiB 1.18 MiB
7eff2d75fa6c1b6600312b339a907ec2b33c93eb+dirty 7.15 MiB 8.35 MiB 1.20 MiB
472960b07b4e7755510707a1204dc75cd3643423+dirty 7.15 MiB 8.34 MiB 1.18 MiB
f870f2d847a00dca3fcf079449beaefce22e9315+dirty 7.15 MiB 8.34 MiB 1.18 MiB

Previous results on branch: lz/v7/ignore-errors

Startup times

Revision Plain With Sentry Diff
628a49042460c731369210efdcb29827d251b098+dirty 370.94 ms 368.02 ms -2.92 ms
000340c45cab7a6e7fd89ef8c7e05c106e42e0ed+dirty 388.30 ms 394.09 ms 5.79 ms

App size

Revision Plain With Sentry Diff
628a49042460c731369210efdcb29827d251b098+dirty 7.15 MiB 8.35 MiB 1.20 MiB
000340c45cab7a6e7fd89ef8c7e05c106e42e0ed+dirty 7.15 MiB 8.35 MiB 1.20 MiB

github-actions[bot] avatar Jun 25 '25 15:06 github-actions[bot]

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1221.81 ms 1227.02 ms 5.21 ms
Size 3.19 MiB 4.36 MiB 1.17 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
7eff2d75fa6c1b6600312b339a907ec2b33c93eb+dirty 1224.84 ms 1227.94 ms 3.10 ms
3c99746b6d73d4c5cf56b537d63f44e4e4e06b46+dirty 1227.65 ms 1228.81 ms 1.16 ms
472960b07b4e7755510707a1204dc75cd3643423+dirty 1243.67 ms 1233.57 ms -10.11 ms
f870f2d847a00dca3fcf079449beaefce22e9315+dirty 1230.08 ms 1238.88 ms 8.80 ms

App size

Revision Plain With Sentry Diff
7eff2d75fa6c1b6600312b339a907ec2b33c93eb+dirty 3.19 MiB 4.36 MiB 1.17 MiB
3c99746b6d73d4c5cf56b537d63f44e4e4e06b46+dirty 3.19 MiB 4.35 MiB 1.16 MiB
472960b07b4e7755510707a1204dc75cd3643423+dirty 3.19 MiB 4.36 MiB 1.17 MiB
f870f2d847a00dca3fcf079449beaefce22e9315+dirty 3.19 MiB 4.36 MiB 1.17 MiB

Previous results on branch: lz/v7/ignore-errors

Startup times

Revision Plain With Sentry Diff
628a49042460c731369210efdcb29827d251b098+dirty 1224.94 ms 1237.40 ms 12.46 ms
000340c45cab7a6e7fd89ef8c7e05c106e42e0ed+dirty 1224.71 ms 1221.85 ms -2.86 ms

App size

Revision Plain With Sentry Diff
628a49042460c731369210efdcb29827d251b098+dirty 3.19 MiB 4.36 MiB 1.17 MiB
000340c45cab7a6e7fd89ef8c7e05c106e42e0ed+dirty 3.19 MiB 4.36 MiB 1.17 MiB

github-actions[bot] avatar Jun 25 '25 15:06 github-actions[bot]

iOS (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1224.10 ms 1230.41 ms 6.31 ms
Size 2.63 MiB 3.79 MiB 1.16 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
7eff2d75fa6c1b6600312b339a907ec2b33c93eb+dirty 1225.34 ms 1234.53 ms 9.19 ms
3c99746b6d73d4c5cf56b537d63f44e4e4e06b46+dirty 1215.12 ms 1222.31 ms 7.18 ms
472960b07b4e7755510707a1204dc75cd3643423+dirty 1213.96 ms 1222.58 ms 8.62 ms
f870f2d847a00dca3fcf079449beaefce22e9315+dirty 1227.18 ms 1232.30 ms 5.12 ms

App size

Revision Plain With Sentry Diff
7eff2d75fa6c1b6600312b339a907ec2b33c93eb+dirty 2.63 MiB 3.79 MiB 1.16 MiB
3c99746b6d73d4c5cf56b537d63f44e4e4e06b46+dirty 2.63 MiB 3.78 MiB 1.15 MiB
472960b07b4e7755510707a1204dc75cd3643423+dirty 2.63 MiB 3.79 MiB 1.15 MiB
f870f2d847a00dca3fcf079449beaefce22e9315+dirty 2.63 MiB 3.79 MiB 1.15 MiB

Previous results on branch: lz/v7/ignore-errors

Startup times

Revision Plain With Sentry Diff
628a49042460c731369210efdcb29827d251b098+dirty 1223.83 ms 1230.18 ms 6.35 ms
000340c45cab7a6e7fd89ef8c7e05c106e42e0ed+dirty 1207.56 ms 1210.43 ms 2.87 ms

App size

Revision Plain With Sentry Diff
628a49042460c731369210efdcb29827d251b098+dirty 2.63 MiB 3.79 MiB 1.16 MiB
000340c45cab7a6e7fd89ef8c7e05c106e42e0ed+dirty 2.63 MiB 3.79 MiB 1.16 MiB

github-actions[bot] avatar Jun 25 '25 15:06 github-actions[bot]