sentry-react-native
sentry-react-native copied to clipboard
feat(expo): Automatically detect Release name and version for Expo Web
:loudspeaker: Type of change
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
:scroll: Description
Automatically detect Release name and version for Expo Web
:bulb: Motivation and Context
Fixes https://github.com/getsentry/sentry-react-native/issues/4894
:green_heart: How did you test it?
Manual, CI
:pencil: Checklist
- [x] I added tests to verify changes
- [x] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled - [x] I updated the docs if needed.
- [x] I updated the wizard if needed.
- [x] All tests passing
- [x] No breaking changes
:crystal_ball: Next steps
| Messages | |
|---|---|
| :book: | Do not forget to update Sentry-docs with your feature once the pull request gets approved. |
Generated by :no_entry_sign: dangerJS against f2648bae3dfa6bb866b0785ac01dd2b78a77fcea
Android (legacy) Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 479.89 ms | 507.74 ms | 27.86 ms |
| Size | 17.75 MiB | 20.16 MiB | 2.41 MiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e12044e190c98086069f543c4872b1290f3dbce7 | 453.78 ms | 437.58 ms | -16.20 ms |
| 7d3c3cbb3ac2afeaa1306c36c7f6ed6b5b87fd02 | 444.85 ms | 456.65 ms | 11.81 ms |
| 69721ae4b31d0938d7524522df3f0511083ed061 | 424.85 ms | 415.28 ms | -9.57 ms |
| 1f1c42023bca1bcda0b9e5028131d627abb85aef | 403.32 ms | 411.98 ms | 8.66 ms |
| f2c6fa59fe513a080e8f60f4a98ac1893239084a | 445.15 ms | 449.13 ms | 3.98 ms |
| b4d6bdebcc77aab0bbfc10483d77eab420d3707b | 425.51 ms | 417.37 ms | -8.14 ms |
| 52d9c3fd55b7ab19168e3accba26bcbab7510402 | 481.48 ms | 468.53 ms | -12.95 ms |
| 6e8a85144bc0b83c20a8bd5e667d4446acc44dd6 | 425.59 ms | 433.51 ms | 7.92 ms |
| a8a0930d8796ea16d9d38605ee1487d62e50bf56 | 397.23 ms | 383.78 ms | -13.45 ms |
| 940bd65839926e7ae9e8b8b3d8d9785cbf3009bd | 466.31 ms | 458.52 ms | -7.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e12044e190c98086069f543c4872b1290f3dbce7 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 7d3c3cbb3ac2afeaa1306c36c7f6ed6b5b87fd02 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 69721ae4b31d0938d7524522df3f0511083ed061 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 1f1c42023bca1bcda0b9e5028131d627abb85aef | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| f2c6fa59fe513a080e8f60f4a98ac1893239084a | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| b4d6bdebcc77aab0bbfc10483d77eab420d3707b | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 52d9c3fd55b7ab19168e3accba26bcbab7510402 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 6e8a85144bc0b83c20a8bd5e667d4446acc44dd6 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| a8a0930d8796ea16d9d38605ee1487d62e50bf56 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 940bd65839926e7ae9e8b8b3d8d9785cbf3009bd | 17.75 MiB | 20.15 MiB | 2.40 MiB |
Previous results on branch: antonis/expo-web-release-version
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d07e72fac41918d307f146713190f47b177a062f | 393.08 ms | 387.92 ms | -5.16 ms |
| f6bb454fece0a8900338abcdec310f3ac756a886 | 434.09 ms | 436.00 ms | 1.91 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d07e72fac41918d307f146713190f47b177a062f | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| f6bb454fece0a8900338abcdec310f3ac756a886 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
Android (new) Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 415.40 ms | 433.73 ms | 18.32 ms |
| Size | 7.15 MiB | 8.43 MiB | 1.27 MiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 940bd65839926e7ae9e8b8b3d8d9785cbf3009bd+dirty | 408.45 ms | 419.75 ms | 11.30 ms |
| 4e2cbd2d3a8cdefc5c984768c36832a24da7d4b5+dirty | 371.98 ms | 392.00 ms | 20.02 ms |
| 69721ae4b31d0938d7524522df3f0511083ed061+dirty | 423.63 ms | 417.34 ms | -6.29 ms |
| 6e8a85144bc0b83c20a8bd5e667d4446acc44dd6+dirty | 403.44 ms | 430.87 ms | 27.43 ms |
| 1f1c42023bca1bcda0b9e5028131d627abb85aef+dirty | 383.31 ms | 386.98 ms | 3.67 ms |
| 866f143bb48270f9a33e9f66b0e6c2b1c9347e15+dirty | 378.91 ms | 368.73 ms | -10.19 ms |
| ec2a485c7a5c6e236205545de48cc3ca09cad803+dirty | 397.67 ms | 390.91 ms | -6.76 ms |
| b4d6bdebcc77aab0bbfc10483d77eab420d3707b+dirty | 390.51 ms | 385.60 ms | -4.91 ms |
| 0e42017ff6f154ae24dc57366b65f48d9dfb9f16+dirty | 387.33 ms | 399.30 ms | 11.97 ms |
| 398e5d0c0e22be60855ae2c490cc4133b020fb0e+dirty | 422.88 ms | 444.98 ms | 22.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 940bd65839926e7ae9e8b8b3d8d9785cbf3009bd+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 4e2cbd2d3a8cdefc5c984768c36832a24da7d4b5+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 69721ae4b31d0938d7524522df3f0511083ed061+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 6e8a85144bc0b83c20a8bd5e667d4446acc44dd6+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 1f1c42023bca1bcda0b9e5028131d627abb85aef+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 866f143bb48270f9a33e9f66b0e6c2b1c9347e15+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| ec2a485c7a5c6e236205545de48cc3ca09cad803+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| b4d6bdebcc77aab0bbfc10483d77eab420d3707b+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 0e42017ff6f154ae24dc57366b65f48d9dfb9f16+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 398e5d0c0e22be60855ae2c490cc4133b020fb0e+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
Previous results on branch: antonis/expo-web-release-version
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f6bb454fece0a8900338abcdec310f3ac756a886+dirty | 402.96 ms | 396.39 ms | -6.57 ms |
| d07e72fac41918d307f146713190f47b177a062f+dirty | 382.49 ms | 370.06 ms | -12.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f6bb454fece0a8900338abcdec310f3ac756a886+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| d07e72fac41918d307f146713190f47b177a062f+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
iOS (new) Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 1223.81 ms | 1232.86 ms | 9.04 ms |
| Size | 3.19 MiB | 4.37 MiB | 1.19 MiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a8a0930d8796ea16d9d38605ee1487d62e50bf56+dirty | 1212.11 ms | 1229.45 ms | 17.34 ms |
| 9e3030a1597ac7452872413ea8344f542bd99266+dirty | 1217.82 ms | 1205.60 ms | -12.21 ms |
| f2c6fa59fe513a080e8f60f4a98ac1893239084a+dirty | 1223.47 ms | 1227.37 ms | 3.90 ms |
| 7d3c3cbb3ac2afeaa1306c36c7f6ed6b5b87fd02+dirty | 1214.56 ms | 1234.53 ms | 19.97 ms |
| ec2a485c7a5c6e236205545de48cc3ca09cad803+dirty | 1209.65 ms | 1229.18 ms | 19.53 ms |
| 69721ae4b31d0938d7524522df3f0511083ed061+dirty | 1251.53 ms | 1253.69 ms | 2.16 ms |
| b4d6bdebcc77aab0bbfc10483d77eab420d3707b+dirty | 1218.73 ms | 1223.26 ms | 4.53 ms |
| df5da5d284c27f13ff80d4c768a30889919072e3+dirty | 1226.82 ms | 1234.88 ms | 8.06 ms |
| 6e8a85144bc0b83c20a8bd5e667d4446acc44dd6+dirty | 1222.57 ms | 1223.67 ms | 1.10 ms |
| 398e5d0c0e22be60855ae2c490cc4133b020fb0e+dirty | 1226.17 ms | 1232.82 ms | 6.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a8a0930d8796ea16d9d38605ee1487d62e50bf56+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 9e3030a1597ac7452872413ea8344f542bd99266+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| f2c6fa59fe513a080e8f60f4a98ac1893239084a+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 7d3c3cbb3ac2afeaa1306c36c7f6ed6b5b87fd02+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| ec2a485c7a5c6e236205545de48cc3ca09cad803+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 69721ae4b31d0938d7524522df3f0511083ed061+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| b4d6bdebcc77aab0bbfc10483d77eab420d3707b+dirty | 3.19 MiB | 4.34 MiB | 1.16 MiB |
| df5da5d284c27f13ff80d4c768a30889919072e3+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 6e8a85144bc0b83c20a8bd5e667d4446acc44dd6+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 398e5d0c0e22be60855ae2c490cc4133b020fb0e+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
Previous results on branch: antonis/expo-web-release-version
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f6bb454fece0a8900338abcdec310f3ac756a886+dirty | 1216.37 ms | 1239.54 ms | 23.17 ms |
| d07e72fac41918d307f146713190f47b177a062f+dirty | 1214.44 ms | 1232.20 ms | 17.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f6bb454fece0a8900338abcdec310f3ac756a886+dirty | 3.19 MiB | 4.36 MiB | 1.18 MiB |
| d07e72fac41918d307f146713190f47b177a062f+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
iOS (legacy) Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 1219.92 ms | 1220.90 ms | 0.98 ms |
| Size | 2.63 MiB | 3.81 MiB | 1.18 MiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a8a0930d8796ea16d9d38605ee1487d62e50bf56+dirty | 1215.90 ms | 1227.82 ms | 11.92 ms |
| 1f1c42023bca1bcda0b9e5028131d627abb85aef+dirty | 1216.77 ms | 1214.48 ms | -2.29 ms |
| 9e3030a1597ac7452872413ea8344f542bd99266+dirty | 1215.35 ms | 1234.80 ms | 19.45 ms |
| b4d6bdebcc77aab0bbfc10483d77eab420d3707b+dirty | 1223.22 ms | 1243.56 ms | 20.34 ms |
| 940bd65839926e7ae9e8b8b3d8d9785cbf3009bd+dirty | 1216.88 ms | 1225.23 ms | 8.35 ms |
| 8bd8033e4c49d0d90a8b0bae22d5e59d7889885c+dirty | 1213.33 ms | 1220.88 ms | 7.55 ms |
| 69721ae4b31d0938d7524522df3f0511083ed061+dirty | 1229.82 ms | 1226.00 ms | -3.82 ms |
| 398e5d0c0e22be60855ae2c490cc4133b020fb0e+dirty | 1225.30 ms | 1219.94 ms | -5.36 ms |
| ec2a485c7a5c6e236205545de48cc3ca09cad803+dirty | 1219.72 ms | 1224.66 ms | 4.94 ms |
| bdb324a11c9a6965cf39589af198b4e2fa50dc8f+dirty | 1229.33 ms | 1236.61 ms | 7.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a8a0930d8796ea16d9d38605ee1487d62e50bf56+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
| 1f1c42023bca1bcda0b9e5028131d627abb85aef+dirty | 2.63 MiB | 3.77 MiB | 1.14 MiB |
| 9e3030a1597ac7452872413ea8344f542bd99266+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
| b4d6bdebcc77aab0bbfc10483d77eab420d3707b+dirty | 2.63 MiB | 3.77 MiB | 1.14 MiB |
| 940bd65839926e7ae9e8b8b3d8d9785cbf3009bd+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 8bd8033e4c49d0d90a8b0bae22d5e59d7889885c+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 69721ae4b31d0938d7524522df3f0511083ed061+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
| 398e5d0c0e22be60855ae2c490cc4133b020fb0e+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
| ec2a485c7a5c6e236205545de48cc3ca09cad803+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| bdb324a11c9a6965cf39589af198b4e2fa50dc8f+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
Previous results on branch: antonis/expo-web-release-version
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f6bb454fece0a8900338abcdec310f3ac756a886+dirty | 1217.15 ms | 1236.38 ms | 19.23 ms |
| d07e72fac41918d307f146713190f47b177a062f+dirty | 1226.68 ms | 1224.77 ms | -1.91 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f6bb454fece0a8900338abcdec310f3ac756a886+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
| d07e72fac41918d307f146713190f47b177a062f+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
Closing in favor of https://github.com/getsentry/sentry-react-native/pull/4967