sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard
verified publisher icon getsentry

Adds breadcrumb origin field

Open antonis opened this issue 1 year ago • 4 comments

:loudspeaker: Type of change

  • [ ] Bugfix
  • [ ] New feature
  • [x] Enhancement
  • [ ] Refactoring

:scroll: Description

Uses breadcrumb.origin field to prevent exception capture context from being overwritten by native scope sync

Depends on:

  • https://github.com/getsentry/sentry-java/pull/3727
  • https://github.com/getsentry/sentry-cocoa/pull/4358
  • https://github.com/getsentry/sentry-docs/pull/11449

:bulb: Motivation and Context

Fixes https://github.com/getsentry/sentry-react-native/issues/2146 The discussion in https://github.com/getsentry/sentry-capacitor/pull/629#discussion_r1617321563 adds some context on the need of a new field to be used internally to solve a technical problem.

:green_heart: How did you test it?

TODO

:pencil: Checklist

  • [ ] I reviewed submitted code
  • [ ] I added tests to verify changes
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • [ ] All tests passing
  • [ ] No breaking changes

:crystal_ball: Next steps

antonis avatar Sep 27 '24 15:09 antonis

iOS (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1221.45 ms 1234.88 ms 13.43 ms
Size 2.36 MiB 3.10 MiB 752.43 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
62a750bd050f26dbf2553deb01e3f453f272de2c+dirty 1216.60 ms 1229.14 ms 12.54 ms
a989877aa578d652ec0683764d802bb6bb6cbd2e+dirty 1228.56 ms 1227.71 ms -0.85 ms
484813b771d99e76c96e5cdea202fdc767bd7cf9+dirty 1222.45 ms 1220.79 ms -1.66 ms
700cbf4afb71e75ce0939b98522893b4ae61d70b+dirty 1234.59 ms 1227.71 ms -6.88 ms
e73d82f5e34d416eca0eb58c76599fb625345e48+dirty 1207.52 ms 1216.73 ms 9.21 ms
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 1210.27 ms 1218.66 ms 8.39 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 1223.20 ms 1236.88 ms 13.68 ms
d7401ac44acf524fe4d9a6a525f2cc13c70ce9e5+dirty 1252.38 ms 1275.04 ms 22.66 ms
b1e87125f5dbad623a4e4293384e68e8f702cc19+dirty 1256.02 ms 1265.14 ms 9.12 ms
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 1244.10 ms 1268.52 ms 24.42 ms

App size

Revision Plain With Sentry Diff
62a750bd050f26dbf2553deb01e3f453f272de2c+dirty 2.36 MiB 2.92 MiB 570.00 KiB
a989877aa578d652ec0683764d802bb6bb6cbd2e+dirty 2.36 MiB 3.10 MiB 752.40 KiB
484813b771d99e76c96e5cdea202fdc767bd7cf9+dirty 2.36 MiB 3.08 MiB 734.18 KiB
700cbf4afb71e75ce0939b98522893b4ae61d70b+dirty 2.36 MiB 3.08 MiB 734.22 KiB
e73d82f5e34d416eca0eb58c76599fb625345e48+dirty 2.36 MiB 3.08 MiB 734.23 KiB
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 2.36 MiB 2.83 MiB 479.25 KiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 2.36 MiB 2.84 MiB 486.85 KiB
d7401ac44acf524fe4d9a6a525f2cc13c70ce9e5+dirty 2.36 MiB 2.83 MiB 481.14 KiB
b1e87125f5dbad623a4e4293384e68e8f702cc19+dirty 2.36 MiB 2.84 MiB 488.84 KiB
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 2.36 MiB 2.82 MiB 469.45 KiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
9cee3c7e0f34aaf4847312ab42fb489abad895d9+dirty 1211.82 ms 1220.43 ms 8.61 ms
093a11fb8a22ca6aa45a005cff3a25625f96da6f+dirty 1212.48 ms 1229.21 ms 16.73 ms
e045c616b5a5624af61e91d99806c8840f8d89f3+dirty 1236.80 ms 1238.87 ms 2.08 ms
e62bf3068fb407de9e22bb33856575a3b18eb5b2+dirty 1238.96 ms 1243.39 ms 4.43 ms
2bd46a70ccb86ace676d171b353ec98ec8dfc394+dirty 1218.10 ms 1220.43 ms 2.32 ms
f7ad13bd3e7bdd526442fa4549c61a2b1e55d7d1+dirty 1217.18 ms 1220.83 ms 3.65 ms
c84e45774174acc866049288ee64223f82c5dcd5+dirty 1218.30 ms 1224.08 ms 5.78 ms
168e871e35b1ab53afd3bca384e6263230e71565+dirty 1205.87 ms 1221.37 ms 15.50 ms
17fc2f74058ab1a6949b9b9da5ef69eec30a50d5+dirty 1216.04 ms 1220.39 ms 4.35 ms

App size

Revision Plain With Sentry Diff
9cee3c7e0f34aaf4847312ab42fb489abad895d9+dirty 2.36 MiB 3.08 MiB 737.39 KiB
093a11fb8a22ca6aa45a005cff3a25625f96da6f+dirty 2.36 MiB 3.10 MiB 752.44 KiB
e045c616b5a5624af61e91d99806c8840f8d89f3+dirty 2.36 MiB 3.10 MiB 753.19 KiB
e62bf3068fb407de9e22bb33856575a3b18eb5b2+dirty 2.36 MiB 3.15 MiB 802.94 KiB
2bd46a70ccb86ace676d171b353ec98ec8dfc394+dirty 2.36 MiB 3.10 MiB 752.72 KiB
f7ad13bd3e7bdd526442fa4549c61a2b1e55d7d1+dirty 2.36 MiB 3.10 MiB 753.14 KiB
c84e45774174acc866049288ee64223f82c5dcd5+dirty 2.36 MiB 3.10 MiB 751.68 KiB
168e871e35b1ab53afd3bca384e6263230e71565+dirty 2.36 MiB 3.08 MiB 736.99 KiB
17fc2f74058ab1a6949b9b9da5ef69eec30a50d5+dirty 2.36 MiB 3.08 MiB 737.22 KiB

github-actions[bot] avatar Oct 08 '24 10:10 github-actions[bot]

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1222.69 ms 1227.90 ms 5.21 ms
Size 2.92 MiB 3.66 MiB 757.00 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
62a750bd050f26dbf2553deb01e3f453f272de2c+dirty 1228.12 ms 1230.53 ms 2.41 ms
a989877aa578d652ec0683764d802bb6bb6cbd2e+dirty 1222.90 ms 1219.89 ms -3.00 ms
484813b771d99e76c96e5cdea202fdc767bd7cf9+dirty 1225.07 ms 1221.00 ms -4.07 ms
700cbf4afb71e75ce0939b98522893b4ae61d70b+dirty 1233.96 ms 1228.27 ms -5.69 ms
e73d82f5e34d416eca0eb58c76599fb625345e48+dirty 1231.20 ms 1228.81 ms -2.40 ms
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 1268.36 ms 1273.04 ms 4.68 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 1266.52 ms 1282.55 ms 16.03 ms
d7401ac44acf524fe4d9a6a525f2cc13c70ce9e5+dirty 1288.10 ms 1289.54 ms 1.44 ms
b1e87125f5dbad623a4e4293384e68e8f702cc19+dirty 1284.11 ms 1297.82 ms 13.71 ms
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 1245.00 ms 1257.76 ms 12.76 ms

App size

Revision Plain With Sentry Diff
62a750bd050f26dbf2553deb01e3f453f272de2c+dirty 2.92 MiB 3.48 MiB 575.59 KiB
a989877aa578d652ec0683764d802bb6bb6cbd2e+dirty 2.92 MiB 3.66 MiB 757.66 KiB
484813b771d99e76c96e5cdea202fdc767bd7cf9+dirty 2.92 MiB 3.64 MiB 740.56 KiB
700cbf4afb71e75ce0939b98522893b4ae61d70b+dirty 2.92 MiB 3.64 MiB 740.57 KiB
e73d82f5e34d416eca0eb58c76599fb625345e48+dirty 2.92 MiB 3.64 MiB 740.56 KiB
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 2.92 MiB 3.39 MiB 485.96 KiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 2.92 MiB 3.40 MiB 492.53 KiB
d7401ac44acf524fe4d9a6a525f2cc13c70ce9e5+dirty 2.92 MiB 3.40 MiB 488.06 KiB
b1e87125f5dbad623a4e4293384e68e8f702cc19+dirty 2.92 MiB 3.40 MiB 494.15 KiB
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 2.92 MiB 3.38 MiB 475.74 KiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
9cee3c7e0f34aaf4847312ab42fb489abad895d9+dirty 1237.08 ms 1232.16 ms -4.92 ms
093a11fb8a22ca6aa45a005cff3a25625f96da6f+dirty 1238.33 ms 1237.33 ms -1.01 ms
e045c616b5a5624af61e91d99806c8840f8d89f3+dirty 1225.21 ms 1230.33 ms 5.12 ms
e62bf3068fb407de9e22bb33856575a3b18eb5b2+dirty 1239.42 ms 1242.14 ms 2.73 ms
2bd46a70ccb86ace676d171b353ec98ec8dfc394+dirty 1230.79 ms 1232.40 ms 1.61 ms
f7ad13bd3e7bdd526442fa4549c61a2b1e55d7d1+dirty 1237.70 ms 1239.14 ms 1.44 ms
c84e45774174acc866049288ee64223f82c5dcd5+dirty 1229.50 ms 1226.76 ms -2.74 ms
168e871e35b1ab53afd3bca384e6263230e71565+dirty 1234.31 ms 1227.67 ms -6.64 ms
17fc2f74058ab1a6949b9b9da5ef69eec30a50d5+dirty 1234.25 ms 1234.78 ms 0.53 ms

App size

Revision Plain With Sentry Diff
9cee3c7e0f34aaf4847312ab42fb489abad895d9+dirty 2.92 MiB 3.64 MiB 743.04 KiB
093a11fb8a22ca6aa45a005cff3a25625f96da6f+dirty 2.92 MiB 3.66 MiB 757.73 KiB
e045c616b5a5624af61e91d99806c8840f8d89f3+dirty 2.92 MiB 3.66 MiB 758.40 KiB
e62bf3068fb407de9e22bb33856575a3b18eb5b2+dirty 2.92 MiB 3.71 MiB 808.09 KiB
2bd46a70ccb86ace676d171b353ec98ec8dfc394+dirty 2.92 MiB 3.66 MiB 757.44 KiB
f7ad13bd3e7bdd526442fa4549c61a2b1e55d7d1+dirty 2.92 MiB 3.66 MiB 758.41 KiB
c84e45774174acc866049288ee64223f82c5dcd5+dirty 2.92 MiB 3.66 MiB 756.01 KiB
168e871e35b1ab53afd3bca384e6263230e71565+dirty 2.92 MiB 3.64 MiB 742.68 KiB
17fc2f74058ab1a6949b9b9da5ef69eec30a50d5+dirty 2.92 MiB 3.64 MiB 743.07 KiB

github-actions[bot] avatar Oct 08 '24 10:10 github-actions[bot]

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 369.18 ms 398.42 ms 29.24 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 339.02 ms 408.65 ms 69.63 ms
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 267.21 ms 325.24 ms 58.04 ms
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 361.27 ms 407.88 ms 46.61 ms
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 371.40 ms 377.70 ms 6.31 ms
e540498478edf6f59bd7e731809a3ea6409dcc1c+dirty 408.56 ms 480.00 ms 71.44 ms
62a750bd050f26dbf2553deb01e3f453f272de2c+dirty 370.78 ms 376.73 ms 5.96 ms
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 375.64 ms 431.59 ms 55.95 ms
c639edf12520d1afee79e1ff2ba18df03ce70ec3+dirty 363.39 ms 414.78 ms 51.39 ms
acadc0f974a0c234a3d9010117b076792d14d6e8+dirty 259.04 ms 304.67 ms 45.63 ms
27ef4ee6faa6d5229b16fca7b728ca6b689ab916+dirty 296.71 ms 351.00 ms 54.29 ms

App size

Revision Plain With Sentry Diff
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 7.15 MiB 8.09 MiB 964.41 KiB
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 7.15 MiB 8.09 MiB 962.69 KiB
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 7.15 MiB 8.12 MiB 997.78 KiB
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 7.15 MiB 8.03 MiB 901.79 KiB
e540498478edf6f59bd7e731809a3ea6409dcc1c+dirty 7.15 MiB 8.38 MiB 1.23 MiB
62a750bd050f26dbf2553deb01e3f453f272de2c+dirty 7.15 MiB 8.21 MiB 1.06 MiB
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 7.15 MiB 8.38 MiB 1.23 MiB
c639edf12520d1afee79e1ff2ba18df03ce70ec3+dirty 7.15 MiB 8.35 MiB 1.20 MiB
acadc0f974a0c234a3d9010117b076792d14d6e8+dirty 7.15 MiB 8.03 MiB 903.20 KiB
27ef4ee6faa6d5229b16fca7b728ca6b689ab916+dirty 7.15 MiB 8.08 MiB 959.49 KiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
17fc2f74058ab1a6949b9b9da5ef69eec30a50d5+dirty 409.50 ms 462.68 ms 53.18 ms
093a11fb8a22ca6aa45a005cff3a25625f96da6f+dirty 415.54 ms 461.00 ms 45.46 ms
9cee3c7e0f34aaf4847312ab42fb489abad895d9+dirty 397.49 ms 454.02 ms 56.53 ms
f7ad13bd3e7bdd526442fa4549c61a2b1e55d7d1+dirty 478.18 ms 564.25 ms 86.07 ms
168e871e35b1ab53afd3bca384e6263230e71565+dirty 508.96 ms 599.09 ms 90.13 ms
c84e45774174acc866049288ee64223f82c5dcd5+dirty 395.52 ms 432.24 ms 36.72 ms
e62bf3068fb407de9e22bb33856575a3b18eb5b2+dirty 369.36 ms 405.27 ms 35.92 ms
e045c616b5a5624af61e91d99806c8840f8d89f3+dirty 434.98 ms 463.36 ms 28.38 ms

App size

Revision Plain With Sentry Diff
17fc2f74058ab1a6949b9b9da5ef69eec30a50d5+dirty 7.15 MiB 8.35 MiB 1.20 MiB
093a11fb8a22ca6aa45a005cff3a25625f96da6f+dirty 7.15 MiB 8.35 MiB 1.20 MiB
9cee3c7e0f34aaf4847312ab42fb489abad895d9+dirty 7.15 MiB 8.35 MiB 1.20 MiB
f7ad13bd3e7bdd526442fa4549c61a2b1e55d7d1+dirty 7.15 MiB 8.35 MiB 1.20 MiB
168e871e35b1ab53afd3bca384e6263230e71565+dirty 7.15 MiB 8.35 MiB 1.20 MiB
c84e45774174acc866049288ee64223f82c5dcd5+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e62bf3068fb407de9e22bb33856575a3b18eb5b2+dirty 7.15 MiB 8.39 MiB 1.24 MiB
e045c616b5a5624af61e91d99806c8840f8d89f3+dirty 7.15 MiB 8.35 MiB 1.20 MiB

github-actions[bot] avatar Oct 10 '24 15:10 github-actions[bot]

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 459.00 ms 442.70 ms -16.30 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c639edf12520d1afee79e1ff2ba18df03ce70ec3 466.48 ms 489.57 ms 23.09 ms
3853f4362ec819042552ffa9ed30e8f6627e60bf 329.68 ms 346.32 ms 16.64 ms
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 335.72 ms 355.52 ms 19.80 ms
4cc5c276b8e06761211f41601792dfcbfc7dd854 460.04 ms 496.32 ms 36.28 ms
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 332.90 ms 352.45 ms 19.55 ms
d2c32bbdb8e91690865169f98c6ef7e2ed672df2 448.85 ms 450.19 ms 1.34 ms
25343377820b65409b646b44bc8e9bc9fbb51c8c 394.15 ms 415.12 ms 20.97 ms
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 430.68 ms 456.13 ms 25.44 ms
b1e87125f5dbad623a4e4293384e68e8f702cc19 462.11 ms 465.71 ms 3.60 ms
cdf2f334f8389e9747b61d338d9ba8945027b0d1 469.46 ms 462.17 ms -7.29 ms

App size

Revision Plain With Sentry Diff
c639edf12520d1afee79e1ff2ba18df03ce70ec3 17.74 MiB 20.08 MiB 2.34 MiB
3853f4362ec819042552ffa9ed30e8f6627e60bf 17.73 MiB 19.81 MiB 2.08 MiB
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 17.73 MiB 20.04 MiB 2.31 MiB
4cc5c276b8e06761211f41601792dfcbfc7dd854 17.73 MiB 19.95 MiB 2.21 MiB
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d2c32bbdb8e91690865169f98c6ef7e2ed672df2 17.74 MiB 20.08 MiB 2.34 MiB
25343377820b65409b646b44bc8e9bc9fbb51c8c 17.73 MiB 19.84 MiB 2.11 MiB
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 17.73 MiB 19.75 MiB 2.01 MiB
b1e87125f5dbad623a4e4293384e68e8f702cc19 17.73 MiB 19.75 MiB 2.02 MiB
cdf2f334f8389e9747b61d338d9ba8945027b0d1 17.74 MiB 20.08 MiB 2.34 MiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
168e871e35b1ab53afd3bca384e6263230e71565 471.56 ms 451.59 ms -19.97 ms
f7ad13bd3e7bdd526442fa4549c61a2b1e55d7d1 488.43 ms 500.04 ms 11.62 ms
e045c616b5a5624af61e91d99806c8840f8d89f3 395.70 ms 386.29 ms -9.41 ms
093a11fb8a22ca6aa45a005cff3a25625f96da6f 471.67 ms 487.81 ms 16.15 ms
9cee3c7e0f34aaf4847312ab42fb489abad895d9 509.72 ms 513.58 ms 3.86 ms
e62bf3068fb407de9e22bb33856575a3b18eb5b2 481.92 ms 471.48 ms -10.44 ms
17fc2f74058ab1a6949b9b9da5ef69eec30a50d5 420.78 ms 512.84 ms 92.07 ms
c84e45774174acc866049288ee64223f82c5dcd5 490.41 ms 489.28 ms -1.13 ms

App size

Revision Plain With Sentry Diff
168e871e35b1ab53afd3bca384e6263230e71565 17.74 MiB 20.08 MiB 2.34 MiB
f7ad13bd3e7bdd526442fa4549c61a2b1e55d7d1 17.74 MiB 20.07 MiB 2.34 MiB
e045c616b5a5624af61e91d99806c8840f8d89f3 17.74 MiB 20.07 MiB 2.34 MiB
093a11fb8a22ca6aa45a005cff3a25625f96da6f 17.74 MiB 20.07 MiB 2.34 MiB
9cee3c7e0f34aaf4847312ab42fb489abad895d9 17.74 MiB 20.08 MiB 2.34 MiB
e62bf3068fb407de9e22bb33856575a3b18eb5b2 17.73 MiB 20.11 MiB 2.38 MiB
17fc2f74058ab1a6949b9b9da5ef69eec30a50d5 17.74 MiB 20.08 MiB 2.34 MiB
c84e45774174acc866049288ee64223f82c5dcd5 17.74 MiB 20.08 MiB 2.34 MiB

github-actions[bot] avatar Oct 11 '24 14:10 github-actions[bot]

Hey @lucas-zimerman, @krystofwoldrich 👋

Fixes https://github.com/getsentry/sentry-react-native/issues/2146 The discussion in https://github.com/getsentry/sentry-capacitor/pull/629#discussion_r1617321563 adds some context on the need of a new field to be used internally to solve a technical problem.

Since some time has passed since the creation of the issue and the discussion above I'd like to verify that the direction I've chosen with this implementation is valid:

Any feedback is welcome 🙏

antonis avatar Oct 28 '24 15:10 antonis

Hey @lucas-zimerman, @krystofwoldrich 👋

Fixes #2146 The discussion in getsentry/sentry-capacitor#629 (comment) adds some context on the need of a new field to be used internally to solve a technical problem.

Since some time has passed since the creation of the issue and the discussion above I'd like to verify that the direction I've chosen with this implementation is valid:

* [Set react-native as breadcrumb origin](https://github.com/getsentry/sentry-react-native/pull/4124/commits/24a527be83850ad4a63b47920b025fc1f7fe7003)

* [Filters out breadcrumbs with `react-native` origin from the native layer](https://github.com/getsentry/sentry-react-native/pull/4124/commits/fabf0526a8b9d70a75c703b2d29accbc09e4fe93)

* [Merges event breadcrumbs with native context](https://github.com/getsentry/sentry-react-native/pull/4124/commits/d0b163342380980a878c340f8ad55df08e86d1a5)

Any feedback is welcome 🙏

The approach looks good indeed, thank you! One thing to note is we should respect maxBreadcrumbs and limit the merged breadcrumbs to the defined value (or 100 if not defined).

lucas-zimerman avatar Oct 29 '24 18:10 lucas-zimerman

Thank you @antonis for checking this.

Set react-native as breadcrumb origin Filters out breadcrumbs with react-native origin from the native layer Merges event breadcrumbs with native context

Yes, all tree steps look good.

  • What @lucas-zimerman mentioned.

krystofwoldrich avatar Oct 30 '24 11:10 krystofwoldrich

@antonis Thank you for the updates. It looks great, I have one last small comment regarding @lucas-zimerman caching question. Then it's good to 🚀

krystofwoldrich avatar Nov 11 '24 10:11 krystofwoldrich

This PR doesn't trigger our dangerous file warning, but I thought anyway we might want to release this as a shot beta before latest release.

krystofwoldrich avatar Nov 11 '24 15:11 krystofwoldrich

I thought anyway we might want to release this as a shot beta before latest release.

This sounds like a good idea ➕

antonis avatar Nov 11 '24 15:11 antonis