sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

feat(e2e): Enable Replay for E2E tests

Open krystofwoldrich opened this issue 1 year ago • 5 comments

:loudspeaker: Type of change

  • [x] Enhancement

:scroll: Description

This PR enables replays for RN E2E tests.

:bulb: Motivation and Context

This should ensure we have the latest state of RN Replay available in Sentry.

:green_heart: How did you test it?

e2e tests

⏭️ : Todo

  • [ ] Add validation, replay was received by the server, included breadcrumbs....

krystofwoldrich avatar Jun 19 '24 08:06 krystofwoldrich

Fails
:no_entry_sign: Please consider adding a changelog entry for the next release.
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Enable Replay for E2E tests ([#3902](https://github.com/getsentry/sentry-react-native/pull/3902))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against bebfa0016c64bf13cb3e9f6e67ed6d6e7baf3923

github-actions[bot] avatar Jun 19 '24 08:06 github-actions[bot]

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 468.18 ms 482.34 ms 14.16 ms
Size 17.73 MiB 20.04 MiB 2.30 MiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d8196b65bca2dd47a43699f03809c383de 429.33 ms 451.24 ms 21.91 ms

App size

Revision Plain With Sentry Diff
41db11d8196b65bca2dd47a43699f03809c383de 17.73 MiB 20.04 MiB 2.30 MiB

github-actions[bot] avatar Jun 19 '24 09:06 github-actions[bot]

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 399.45 ms 437.38 ms 37.94 ms
Size 7.15 MiB 8.31 MiB 1.16 MiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d8196b65bca2dd47a43699f03809c383de+dirty 374.57 ms 415.25 ms 40.68 ms

App size

Revision Plain With Sentry Diff
41db11d8196b65bca2dd47a43699f03809c383de+dirty 7.15 MiB 8.31 MiB 1.16 MiB

github-actions[bot] avatar Jun 19 '24 09:06 github-actions[bot]

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1225.47 ms 1229.47 ms 4.00 ms
Size 2.92 MiB 3.61 MiB 705.83 KiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d8196b65bca2dd47a43699f03809c383de+dirty 1208.60 ms 1210.47 ms 1.87 ms

App size

Revision Plain With Sentry Diff
41db11d8196b65bca2dd47a43699f03809c383de+dirty 2.92 MiB 3.61 MiB 705.84 KiB

github-actions[bot] avatar Jun 19 '24 09:06 github-actions[bot]

Just enabling replay for e2e test is not enough, the test end before segment is uploaded.

Note: Currently we don't have a way to wait for Replay flush.

krystofwoldrich avatar Jun 25 '24 09:06 krystofwoldrich