sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

feat(ReactNativeClientOptions): Remove "tunnel" option

Open AliReza99 opened this issue 1 year ago • 3 comments

Remove the "tunnel" option from the ReactNativeClientOptions type due to lack of support in React Native.

This pull request removes the "tunnel" option from the ReactNativeClientOptions type. While passing this option currently does not create issues, its presence can cause confusion, leading developers to believe that the feature works when it does not. Removing it ensures clarity and avoids potential misunderstandings in React Native projects.

AliReza99 avatar Apr 21 '24 07:04 AliReza99

https://github.com/getsentry/sentry-react-native/issues/3258

AliReza99 avatar Apr 21 '24 07:04 AliReza99

Hi @AliReza99, thank you for the PR, we agree having the option when it's not supported is confusing.

krystofwoldrich avatar Apr 24 '24 16:04 krystofwoldrich

Thanks for your response, @krystofwoldrich .

I appreciate your understanding of the confusion caused by the unsupported "tunnel" option.

Removing the "tunnel" type is crucial because its presence leads developers to debug their apps unnecessarily, given the lack of documentation indicating its unsupported status. This change helps to streamline the development process by preventing wasted time and effort.

AliReza99 avatar Apr 25 '24 05:04 AliReza99

I pulled your changes and fixed the build and added changelog.

  • https://github.com/getsentry/sentry-react-native/pull/3787

krystofwoldrich avatar Apr 29 '24 15:04 krystofwoldrich