sentry-react-native
sentry-react-native copied to clipboard
Added ability to provide sentryUrl
:loudspeaker: Type of change
- [ ] Bugfix
- [ ] New feature
- [X] Enhancement
- [ ] Refactoring
:scroll: Description
Added sentryUrl for people that are self hosting
:bulb: Motivation and Context
Its also possible to define URL inside app.json and this was missing from the command.
:green_heart: How did you test it?
I tested it locally.
:pencil: Checklist
- [X] I reviewed submitted code
- [ ] I added tests to verify changes
- [ ] No new PII added or SDK only sends newly added PII if
sendDefaultPII
is enabled - [ ] All tests passing
- [ ] No breaking changes
:crystal_ball: Next steps
@Acetyld Hi, thank you for the PR,
this makes sense and is a good addition to the Expo script.
But before we can add it the code needs a few fixes that I described in the comments above.
Hi =) Yhea i used the browser vscode editor, it was a bit wonky. Sry for committing above unrelated changed ^^
I saw u fixed almost all issue's so i suppose it is fine now?
@Acetyld There is just this one comment to be resolved.
Alright i tried to update above, if it still incorrect i will put time into doing this in a real editor instead of the git edit 😜
- Fixed merge in https://github.com/getsentry/sentry-react-native/pull/3679